1242718 - Enable selection events outside of nightly

Status: RESOLVED DUPLICATE of bug 1231923

(Core :: DOM: Events, defect)

Description

[cyril.auburtin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.13 Safari/537.36

Steps to reproduce:

demo: http://jsfiddle.net/3wLt19ca/2/


Actual results:

wen selecting text, nothing happen in console, no selectionchange events


Expected results:

it should logs those events

Comment 1

[cyril.auburtin]

works on nightly

Comment 2

[YF (Yang)]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9771bd5e56edd07e21cf008dcadc20d7ed970ce3&tochange=9ed17db42e3e46f1c712e4dffd62d54e915e0fac

Bug 1196479 - Fire selectstart and selectionchange events on the input node when the selection in that editor changes. r=ehsan


See also bug 1248148, it has an opposite expectations.

Comment 3

[cyril.auburtin]

document.addEventListener('selectionchange', e=>console.log('sel change')) is still not working in stable 47 and beta 48

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Have we not enabled the events yet?

Comment 5

[Nika Layzell [:nika] (ni? for response)]

(In reply to Olli Pettay [:smaug] (high review load, please consider other reviewers) from comment #4)
> Have we not enabled the events yet?

I don't believe we have enabled them yet. To do that we just need to set the dom.select_events.enabled pref.

Comment 6

[cyril.auburtin]

Thanks for enabling it, could you tell me for which version it'll land for sure? 
I've a polyfill http://jsfiddle.net/crl/rk6f74tw/32/ but I'd like to use only when necessary

Comment 7

[cyril.auburtin]

50 maybe?

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Enable selection events outside of nightly

This patch enables selection events outside of nightly

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8764388 [details] [diff] [review]
Enable selection events outside of nightly

Review of attachment 8764388 [details] [diff] [review]:
-----------------------------------------------------------------

Smaug, do you think we're ready to enable these outside of nightly?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8764388 [details] [diff] [review]
Enable selection events outside of nightly

I guess so. At least we'd get more feedback and if there are regressions on aurora/beta, we can disable easily.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08845358703f
Enable selection events outside of nightly, r=smaug

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/08845358703f

Comment 13

[Nika Layzell [:nika] (ni? for response)]

Re-opening because of backout coming in bug 1280534 - Should be re-landable once bug 1298970 is fixed.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/21fb1f17d958

Comment 15

[Ryan VanderMeulen [:RyanVM]]

And from Aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/6b222a7b59be