Use the in-content info pages style also for noAccountBox and corruptLogScreen

RESOLVED FIXED in Instantbird 47

Status

Instantbird
Other
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

trunk
Instantbird 47

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
In bug 1247676 aleth mentioned also the corruptLogScreen to change to the in-content info page style.
(Assignee)

Comment 1

3 years ago
Created attachment 8719180 [details] [diff] [review]
IB-inContentStyle.patch

I also found the noAccountBox in accounts.xul which needed the new style too.

On Linux and Windows the old error-48.png did also no more exist.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8719180 - Flags: review?(aleth)

Comment 2

3 years ago
Created attachment 8719211 [details]
Screen Shot.png

Did you intend the background to be white instead of in-content gray?

Comment 3

3 years ago
(In reply to Richard Marti (:Paenglab) from comment #1)
> I also found the noAccountBox in accounts.xul which needed the new style too.
> 
> On Linux and Windows the old error-48.png did also no more exist.

Good catch, thanks!
(Assignee)

Comment 4

3 years ago
(In reply to aleth [:aleth] from comment #2)
> Created attachment 8719211 [details]
> Screen Shot.png
> 
> Did you intend the background to be white instead of in-content gray?

Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field, the nearest to #fbfbf, to be high contrast capable. The in-content pages which are html pages don't use in HC the CSS colors. But our XUL pages do always use it and then the background would be still #fbfbf.

Comment 5

3 years ago
(In reply to Richard Marti (:Paenglab) from comment #4)
> Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field,
> the nearest to #fbfbf, to be high contrast capable. The in-content pages
> which are html pages don't use in HC the CSS colors. But our XUL pages do
> always use it and then the background would be still #fbfbf.

Should someone point out to Fx UX that their in-content CSS isn't high contrast capable? ;)

Updated

3 years ago
Attachment #8719180 - Flags: review?(aleth) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

3 years ago
(In reply to aleth [:aleth] from comment #5)
> (In reply to Richard Marti (:Paenglab) from comment #4)
> > Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field,
> > the nearest to #fbfbf, to be high contrast capable. The in-content pages
> > which are html pages don't use in HC the CSS colors. But our XUL pages do
> > always use it and then the background would be still #fbfbf.
> 
> Should someone point out to Fx UX that their in-content CSS isn't high
> contrast capable? ;)

You misunderstood me. They are automatically HC capable because they are loaded in a browser content page.

Comment 7

3 years ago
https://hg.mozilla.org/comm-central/rev/4ffdbec0f2778c4abcc1ee8764eb89cdb9b6e36d
Bug 1248157 - Change more info-/error screens to in-content info page style. r=aleth

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 47
You need to log in before you can comment on or make changes to this bug.