Closed Bug 1248157 Opened 5 years ago Closed 5 years ago

Use the in-content info pages style also for noAccountBox and corruptLogScreen

Categories

(Instantbird :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 47

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

In bug 1247676 aleth mentioned also the corruptLogScreen to change to the in-content info page style.
I also found the noAccountBox in accounts.xul which needed the new style too.

On Linux and Windows the old error-48.png did also no more exist.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8719180 - Flags: review?(aleth)
Attached image Screen Shot.png
Did you intend the background to be white instead of in-content gray?
(In reply to Richard Marti (:Paenglab) from comment #1)
> I also found the noAccountBox in accounts.xul which needed the new style too.
> 
> On Linux and Windows the old error-48.png did also no more exist.

Good catch, thanks!
(In reply to aleth [:aleth] from comment #2)
> Created attachment 8719211 [details]
> Screen Shot.png
> 
> Did you intend the background to be white instead of in-content gray?

Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field, the nearest to #fbfbf, to be high contrast capable. The in-content pages which are html pages don't use in HC the CSS colors. But our XUL pages do always use it and then the background would be still #fbfbf.
(In reply to Richard Marti (:Paenglab) from comment #4)
> Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field,
> the nearest to #fbfbf, to be high contrast capable. The in-content pages
> which are html pages don't use in HC the CSS colors. But our XUL pages do
> always use it and then the background would be still #fbfbf.

Should someone point out to Fx UX that their in-content CSS isn't high contrast capable? ;)
Attachment #8719180 - Flags: review?(aleth) → review+
Keywords: checkin-needed
(In reply to aleth [:aleth] from comment #5)
> (In reply to Richard Marti (:Paenglab) from comment #4)
> > Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field,
> > the nearest to #fbfbf, to be high contrast capable. The in-content pages
> > which are html pages don't use in HC the CSS colors. But our XUL pages do
> > always use it and then the background would be still #fbfbf.
> 
> Should someone point out to Fx UX that their in-content CSS isn't high
> contrast capable? ;)

You misunderstood me. They are automatically HC capable because they are loaded in a browser content page.
https://hg.mozilla.org/comm-central/rev/4ffdbec0f2778c4abcc1ee8764eb89cdb9b6e36d
Bug 1248157 - Change more info-/error screens to in-content info page style. r=aleth
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 47
You need to log in before you can comment on or make changes to this bug.