1248157 - Use the in-content info pages style also for noAccountBox and corruptLogScreen

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[Richard Marti (:Paenglab)]

In bug 1247676 aleth mentioned also the corruptLogScreen to change to the in-content info page style.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: IB-inContentStyle.patch

I also found the noAccountBox in accounts.xul which needed the new style too.

On Linux and Windows the old error-48.png did also no more exist.

Comment 2

[aleth [:aleth]]

Attachment: Screen Shot.png

Did you intend the background to be white instead of in-content gray?

Comment 3

[aleth [:aleth]]

(In reply to Richard Marti (:Paenglab) from comment #1)
> I also found the noAccountBox in accounts.xul which needed the new style too.
> 
> On Linux and Windows the old error-48.png did also no more exist.

Good catch, thanks!

Comment 4

[Richard Marti (:Paenglab)]

(In reply to aleth [:aleth] from comment #2)
> Created attachment 8719211 [details]
> Screen Shot.png
> 
> Did you intend the background to be white instead of in-content gray?

Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field, the nearest to #fbfbf, to be high contrast capable. The in-content pages which are html pages don't use in HC the CSS colors. But our XUL pages do always use it and then the background would be still #fbfbf.

Comment 5

[aleth [:aleth]]

(In reply to Richard Marti (:Paenglab) from comment #4)
> Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field,
> the nearest to #fbfbf, to be high contrast capable. The in-content pages
> which are html pages don't use in HC the CSS colors. But our XUL pages do
> always use it and then the background would be still #fbfbf.

Should someone point out to Fx UX that their in-content CSS isn't high contrast capable? ;)

Comment 6

[Richard Marti (:Paenglab)]

(In reply to aleth [:aleth] from comment #5)
> (In reply to Richard Marti (:Paenglab) from comment #4)
> > Yes, because the in-content pages are using #fbfbfb. I choose -moz-Field,
> > the nearest to #fbfbf, to be high contrast capable. The in-content pages
> > which are html pages don't use in HC the CSS colors. But our XUL pages do
> > always use it and then the background would be still #fbfbf.
> 
> Should someone point out to Fx UX that their in-content CSS isn't high
> contrast capable? ;)

You misunderstood me. They are automatically HC capable because they are loaded in a browser content page.

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/4ffdbec0f2778c4abcc1ee8764eb89cdb9b6e36d
Bug 1248157 - Change more info-/error screens to in-content info page style. r=aleth