1248312 - Change DecodedStream to be pull-based

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

See bug 1244035 comment 0.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c35b85dfcf79

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1248312. Part 1 - Change DecodedStream to be pull-based. r=roc.

Review commit: https://reviewboard.mozilla.org/r/35055/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35055/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1248312. Part 2 - It is bad for DecodedStreamGraphListener to access the audio/vdieo queue after DecodedStream::Stop(). However, DecodedStream::Stop() can't be synchronous because it involves main thread activities.

Review commit: https://reviewboard.mozilla.org/r/35057/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35057/

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm still not sure we really want to do this. Maybe we should at least wait for bug 1201363 to be finished first, since this impacts that and I think bug 1201363 is more important.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

OK. This is not an urgent bug. We can wait for bug 1201363.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

I have some bugs depends on bug 1244035. So I still want to fix this bug as soon as possible. In order not to delay bug 1201363, I can enable pull mode for audio track only. For video track, we will still use push-model like before.

Hi Ctai,
Does my proposal sound reasonable and minimize the impact on your bug 1201363?

Comment 7

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

LGTM so far. The patch which related to DecodedStream is in below link:
https://reviewboard.mozilla.org/r/42465/diff/1#6
You can double check it if you want.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Looks fine to me. The patch only changes the code about video.

Comment 9

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Please f? me before review. I can test it locally.

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

OK.

Comment 11

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3