Closed
Bug 1248498
Opened 7 years ago
Closed 5 years ago
Debugger shows stale HTML files if toolbox disabled caching
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(firefox60 verified)
VERIFIED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | verified |
People
(Reporter: jryans, Assigned: jryans)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
For HTML files with inline scripts, we currently load them from cache. However, the toolbox default to disabling caching for the page. When these concepts combine, we can end up loading stale content for HTML sources.
Assignee | ||
Comment 1•7 years ago
|
||
I assume this should have a test... Are there existing tests that toggle file caching like this?
Attachment #8719623 -
Flags: feedback?(nfitzgerald)
Updated•7 years ago
|
Attachment #8719623 -
Flags: feedback?(nfitzgerald)
Assignee | ||
Comment 3•7 years ago
|
||
Let's try that again...
Attachment #8719623 -
Attachment is obsolete: true
Flags: needinfo?(jryans)
Attachment #8720097 -
Flags: feedback?(nfitzgerald)
Updated•7 years ago
|
Attachment #8720097 -
Flags: feedback?(nfitzgerald) → feedback+
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Comment 4•6 years ago
|
||
Bug 1060732 might be related, we should re-test this after it lands.
See Also: → 1060732
Assignee | ||
Updated•5 years ago
|
Assignee: jryans → nobody
Status: ASSIGNED → NEW
Assignee | ||
Updated•5 years ago
|
Blocks: netmonitor-cache
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Assignee | ||
Updated•5 years ago
|
Attachment #8720097 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=458fd2c970979ee32b1eb1accd5e340dd9dcca8e
Comment 7•5 years ago
|
||
mozreview-review |
Comment on attachment 8954998 [details] Bug 1248498 - Check document cache status when loading HTML sources. https://reviewboard.mozilla.org/r/224180/#review230224 Looks great!
Attachment #8954998 -
Flags: review?(jlaster) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4e8f908acef6cee0728943837bc9b58b14c7b63
Assignee | ||
Comment 10•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=623b5647b1f0bdae513c21ed193a753dc5ff14f9
Comment hidden (mozreview-request) |
Comment 12•5 years ago
|
||
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f0a37e176064 Check document cache status when loading HTML sources. r=jlast
Comment 13•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f0a37e176064
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Assignee | ||
Comment 14•5 years ago
|
||
Erik, a fix for this is now included in Nightly 60. Could you try it out[1] to check whether it resolves the issue you were seeing? [1]: https://nightly.mozilla.org
Flags: needinfo?(erik.krause)
Comment 15•5 years ago
|
||
Seems to be fixed in nightly 60.0a1 (2018-03-06) (64-Bit) but not in developer edition 60.0b1 (64-Bit).
Flags: needinfo?(erik.krause)
Assignee | ||
Comment 16•5 years ago
|
||
Thanks! I believe it should appear in Dev Ed in a few days.
Assignee | ||
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•