1248570 - Firefox can't play wav in video or audio element

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

In DecoderTraits.cpp we read:

>  if (IsWaveType(nsDependentCString(aMIMEType))) {
>    // We should not return true for Wave types, since there are some
>    // Wave codecs actually in use in the wild that we don't support, and
>    // we should allow those to be handled by plugins or helper apps.
>    // Furthermore people can play Wave files on most platforms by other
>    // means.
>    return false;
>  }

Following bug 1231793, we should be able to play most of them now.

No reason to prevent it from running

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1248570: Allow WAV into media element. r?lchristie

Review commit: https://reviewboard.mozilla.org/r/35091/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35091/

Comment 2

[Louis Christie [:lchristie]]

Comment on attachment 8719753 [details]
MozReview Request: Bug 1248570: Allow WAV into media element. r?lchristie

https://reviewboard.mozilla.org/r/35091/#review31731

Looks good to me. I'm fairly confident that after bug 524109 and bug 851530 we'll have support for nearly all uses of wave files.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8719753 [details]
MozReview Request: Bug 1248570: Allow WAV into media element. r?lchristie

https://reviewboard.mozilla.org/r/35091/#review31801

carrying r+ now that lchristie is known by mozreview

Comment 4

[Louis Christie [:lchristie]]

https://reviewboard.mozilla.org/r/35091/#review31803

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3f7abd15aeb

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/283a51c2b59c

Comment 7

[Jean-Yves Avenard [:jya]]

Reverting as roc pointed out we still don't play many of the file:
https://en.wikipedia.org/wiki/WAV#WAV_file_audio_coding_formats_compared

Our WAV demuxer can't handle codec of a different type than PCM this is wrong.

Comment 8

[Louis Christie [:lchristie]]

Indeed, the full list is here: http://www.rfc-editor.org/rfc/rfc2361.txt

So the question is whether we want to support playing the files we can play as Video Document, have an error for those we can't (and still allow them to be downloaded with "save link as"), or to continue the current behavior of opening the download dialogue automatically.

Is there some way to trigger the download pop-up if it's in a Video Document and we fail on WaveDataDecoder::IsWave()?

Comment 9

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 10

[684sigma]

(In reply to Louis Christie [:lchristie] from comment #8)
> So the question is whether we want to support playing the files we can play
> as Video Document, have an error for those we can't (and still allow them to
> be downloaded with "save link as"), or to continue the current behavior of
> opening the download dialogue automatically.

Most likely a duplicate bug: Bug 1337989

Comment 11

[alex_mayorga]

¡Hola!

Ended up here from https://support.mozilla.org/es/questions/1234703

Updating flags FWIW.

¡Gracias!
Alex

Comment 14

[Firefox Bug Husbandry Bot]

Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.

Comment 15

[Firefox Bug Husbandry Bot]

See bug 1547409. Migrating whiteboard priority tags to program flags.

Comment 16

[guest271314]

WAV does playback at video and audio element at Firefox 75 and Nightly 78. However, when navigating directly to the file prompt to download https://bugzilla.mozilla.org/show_bug.cgi?id=1247826.

Comment 17

[Job Bautista]

Should we close this as a duplicate of 1247826 then?