Firefox can't play wav in video or audio element

NEW
Assigned to

Status

()

P3
normal
3 years ago
20 days ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
Points:
---
Bug Flags:
webcompat ?

Firefox Tracking Flags

(firefox47 affected)

Details

(Whiteboard: [webcompat])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In DecoderTraits.cpp we read:

>  if (IsWaveType(nsDependentCString(aMIMEType))) {
>    // We should not return true for Wave types, since there are some
>    // Wave codecs actually in use in the wild that we don't support, and
>    // we should allow those to be handled by plugins or helper apps.
>    // Furthermore people can play Wave files on most platforms by other
>    // means.
>    return false;
>  }

Following bug 1231793, we should be able to play most of them now.

No reason to prevent it from running
(Assignee)

Comment 1

3 years ago
Created attachment 8719753 [details]
MozReview Request: Bug 1248570: Allow WAV into media element. r?lchristie

Review commit: https://reviewboard.mozilla.org/r/35091/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35091/
(Assignee)

Updated

3 years ago
Assignee: nobody → jyavenard
(Assignee)

Updated

3 years ago
Attachment #8719753 - Flags: review?(lchristie)
Attachment #8719753 - Flags: review?(lchristie) → review+
Comment on attachment 8719753 [details]
MozReview Request: Bug 1248570: Allow WAV into media element. r?lchristie

https://reviewboard.mozilla.org/r/35091/#review31731

Looks good to me. I'm fairly confident that after bug 524109 and bug 851530 we'll have support for nearly all uses of wave files.
(Assignee)

Updated

3 years ago
Attachment #8719753 - Flags: review+
(Assignee)

Comment 3

3 years ago
Comment on attachment 8719753 [details]
MozReview Request: Bug 1248570: Allow WAV into media element. r?lchristie

https://reviewboard.mozilla.org/r/35091/#review31801

carrying r+ now that lchristie is known by mozreview
(Assignee)

Comment 7

3 years ago
Reverting as roc pointed out we still don't play many of the file:
https://en.wikipedia.org/wiki/WAV#WAV_file_audio_coding_formats_compared

Our WAV demuxer can't handle codec of a different type than PCM this is wrong.
Indeed, the full list is here: http://www.rfc-editor.org/rfc/rfc2361.txt

So the question is whether we want to support playing the files we can play as Video Document, have an error for those we can't (and still allow them to be downloaded with "save link as"), or to continue the current behavior of opening the download dialogue automatically.

Is there some way to trigger the download pop-up if it's in a Video Document and we fail on WaveDataDecoder::IsWave()?
Priority: -- → P2
Mass change P2 -> P3
Priority: P2 → P3

Comment 10

a year ago
(In reply to Louis Christie [:lchristie] from comment #8)
> So the question is whether we want to support playing the files we can play
> as Video Document, have an error for those we can't (and still allow them to
> be downloaded with "save link as"), or to continue the current behavior of
> opening the download dialogue automatically.

Most likely a duplicate bug: Bug 1337989

Updated

2 months ago

Updated

2 months ago
Flags: webcompat?
Whiteboard: [webcompat]
You need to log in before you can comment on or make changes to this bug.