Closed
Bug 1248993
Opened 9 years ago
Closed 9 years ago
Add a UITest to verify the behavior of the Edit button on the LoginListViewController
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sleroux, Assigned: aaronraimist, Mentored)
Details
Attachments
(1 file)
Follow up bug for https://bugzilla.mozilla.org/show_bug.cgi?id=1246923 to add a test to validate the various scenarios where we can show/hide the edit button.
|
Reporter | |
Comment 1•9 years ago
|
||
Hey Aaron,
I saw you were interested in working on this follow up to the 'Edit' bug you resolved last week. Still interested?
Mentor: sleroux
Flags: needinfo?(aaronraimist)
|
Assignee | |
Comment 2•9 years ago
|
||
Does this patch make sense? I don't have much experience writing tests but this seems to work.
Assignee: nobody → aaronraimist
Status: NEW → ASSIGNED
Flags: needinfo?(aaronraimist)
Attachment #8721692 -
Flags: review?(sleroux)
|
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8721692 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1554
Yup this works great! Thanks for adding the UI test.
Attachment #8721692 -
Flags: review?(sleroux) → review+
|
|
Reporter | |
Comment 4•9 years ago
|
||
If you're interested in another bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1249632
|
|
Reporter | |
Comment 5•9 years ago
|
||
master 94c0163010124fc087fcf3388c8ac0e31b15c51a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•