Follow up bug for https://bugzilla.mozilla.org/show_bug.cgi?id=1246923 to add a test to validate the various scenarios where we can show/hide the edit button.
Hey Aaron, I saw you were interested in working on this follow up to the 'Edit' bug you resolved last week. Still interested?
Created attachment 8721692 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1554 Does this patch make sense? I don't have much experience writing tests but this seems to work.
Assignee: nobody → aaronraimist
Status: NEW → ASSIGNED
Attachment #8721692 - Flags: review?(sleroux)
Comment on attachment 8721692 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1554 Yup this works great! Thanks for adding the UI test.
Attachment #8721692 - Flags: review?(sleroux) → review+
If you're interested in another bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1249632
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.