Add a UITest to verify the behavior of the Edit button on the LoginListViewController

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sleroux, Assigned: aaronraimist, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Follow up bug for https://bugzilla.mozilla.org/show_bug.cgi?id=1246923 to add a test to validate the various scenarios where we can show/hide the edit button.
(Reporter)

Comment 1

3 years ago
Hey Aaron,

I saw you were interested in working on this follow up to the 'Edit' bug you resolved last week. Still interested?
Mentor: sleroux
Flags: needinfo?(aaronraimist)
(Assignee)

Comment 2

3 years ago
Created attachment 8721692 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1554

Does this patch make sense? I don't have much experience writing tests but this seems to work.
Assignee: nobody → aaronraimist
Status: NEW → ASSIGNED
Flags: needinfo?(aaronraimist)
Attachment #8721692 - Flags: review?(sleroux)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8721692 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1554

Yup this works great! Thanks for adding the UI test.
Attachment #8721692 - Flags: review?(sleroux) → review+
(Reporter)

Comment 4

3 years ago
If you're interested in another bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1249632
(Reporter)

Comment 5

3 years ago
master 94c0163010124fc087fcf3388c8ac0e31b15c51a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.