1249358 - Investigate using chunked compression in TelemetryUploadService

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

As gps points out in bug 1244861 comment 20, non-chunked transfer can take up more memory than chunked transfer. This becomes particularly relevant when we start uploading larger pings (e.g. bug 1220171, whatever Java ping we send after "core" – "main", is it?). It'd be great not to use up the user's memory.

Additionally, it'd be great to remove the GzipNonChunkedCompressingEntity code I added so we don't have to maintain it.

As bug 1244861 comment 22 explains, I hit an issue where I received an HTTP 411 error: length required. It's most likely that the HTTP headers were not sent correctly for the GzipCompressingEntity.

Investigate!

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To be explicit, I would try to figure out what headers are being sent in our TelemetryUploadService code when uploading the core ping. Either A) sniff the outgoing packets, B) breakpoint the appropriate code in the debugger, or C) log the outgoing packets.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

fwiw, if the HTTP headers appear to be set up correctly (afaik TRANSFER_ENCODING == something-like-gzip), then it's probably the telemetry server's fault and we need to escalate.

Comment 3

[swaroop.rao]

If this is not considered as a very complex bug, I would like to take it up. I've got a build up and running and I've got some experience working on and fixing bugs in Fennec in the past.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to swaroop.rao from comment #3)
> If this is not considered as a very complex bug, I would like to take it up.
> I've got a build up and running and I've got some experience working on and
> fixing bugs in Fennec in the past.

I'm not familiar with this part of the code and mcomella does not have time to mentor this currently. I'd suggest finding a different bug - let's talk on IRC and find you something.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.