1249850 - Several string fixes in msgSecurityInfo.properties, both for mail and suite

Status: RESOLVED FIXED

(Mozilla Localizations :: en-GB / English (United Kingdom), defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

+++ This bug was initially created as a clone of Bug #1247905 +++

A couple of strings in msgSecurityInfo.properties in both mail and suite contained tpyos and/or a trailing space. Those strings are changed in bug 1247905 without changing the entity name, because it is unlikely that localizers have translated the gramma errors.

However, the en-GB-version of this file seems to contain the exact same (untranslated) errors and need to be fixed too…

Comment 1

[Jorg K (CEST = GMT+2)]

Would you care to attach a patch ;-)

Comment 2

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: msgSecurityInfoProperties-en-GB.patch [Checked in: Comment 8]

Comment 3

[Jorg K (CEST = GMT+2)]

So you have bug 1249850 for en-GB (this one) and bug 1249851 for en-ZA.
I don't understand the patch, it's for
mail/chrome/messenger-smime/msgSecurityInfo.properties and
suite/chrome/mailnews/smime/msgSecurityInfo.properties
So that's relative to some localised repository? Surely the localisers will know what to do with it.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Jorg K (GMT+1) from comment #3)
> So you have bug 1249850 for en-GB (this one) and bug 1249851 for en-ZA.
> I don't understand the patch, it's for
> mail/chrome/messenger-smime/msgSecurityInfo.properties and
> suite/chrome/mailnews/smime/msgSecurityInfo.properties
> So that's relative to some localised repository? Surely the localisers will
> know what to do with it.

That's confusing, you're the one who asked for a patch ;-) 

This bug is filed against en-GB, and the fix will need to land in
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB

I presume Onno assumed you were part of the en-GB team, given your ask.

Also note that en-ZA works on Pootle, so the patch will never land in Mercurial, eventually a fix will land from Pootle.

Comment 5

[Onno Ekker [:nONoNonO UTC+1]]

Ian, I see you are very active on en-GB. Can you check in this patch please?

Comment 6

[Carsten Book [:Tomcat]]

(In reply to Onno Ekker [:nONoNonO UTC+1] from comment #5)
> Ian, I see you are very active on en-GB. Can you check in this patch please?

Comment 7

[Francesco Lodolo [:flod]]

Let's not use the checkin-needed keyword, since it's used by sheriffs and they have nothing to do with l10n repositories.

@Ian
Can you take a look please?

Comment 8

[Ian Neal]

Comment on attachment 8721614 [details] [diff] [review]
msgSecurityInfoProperties-en-GB.patch [Checked in: Comment 8]

http://hg.mozilla.org/releases/l10n/mozilla-release/en-GB/rev/78dbb68b0f20
http://hg.mozilla.org/releases/l10n/mozilla-release/en-GB/rev/3343459798e2
http://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB/rev/b59d401bbe03
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/53f84bbc8398
http://hg.mozilla.org/l10n-central/en-GB/rev/53f84bbc8398

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Ian Neal from comment #8)
> Comment on attachment 8721614 [details] [diff] [review]
> msgSecurityInfoProperties-en-GB.patch [Checked in: Comment 8]
> 
> http://hg.mozilla.org/releases/l10n/mozilla-release/en-GB/rev/78dbb68b0f20
> http://hg.mozilla.org/releases/l10n/mozilla-release/en-GB/rev/3343459798e2

For future reference you shouldn't be landing on mozilla-release repositories: it doesn't have a practical effect, but I'm afraid it could mess up with merge procedures (not completely sure).

Comment 10

[Ian Neal]

(In reply to Francesco Lodolo [:flod] from comment #9)
> (In reply to Ian Neal from comment #8)
> > Comment on attachment 8721614 [details] [diff] [review]
> > msgSecurityInfoProperties-en-GB.patch [Checked in: Comment 8]
> > 
> > http://hg.mozilla.org/releases/l10n/mozilla-release/en-GB/rev/78dbb68b0f20
> > http://hg.mozilla.org/releases/l10n/mozilla-release/en-GB/rev/3343459798e2
> 
> For future reference you shouldn't be landing on mozilla-release
> repositories: it doesn't have a practical effect, but I'm afraid it could
> mess up with merge procedures (not completely sure).

I was trying to get it onto ESR