Closed Bug 1250032 Opened 9 years ago Closed 9 years ago

[Marketplace] Hint should show after the app finish loading

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.6 S8 - 2/26
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: tchen, Assigned: rickychien)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] rickychien:show-hint-after-load > mozilla-b2g:master
46 bytes, text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.5+
Details | Review 
When user open an app from marketplace, the hint of "add to app folder" should show up after the app finish loading.

https://drive.google.com/open?id=0B4dMhI4hp32OWllCWHBkQXlnbFE (v2.3 p22)
No longer depends on: 1248853
ni Ricky
Flags: needinfo?(rchien)
It makes sense to me, I'll take over this.
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: needinfo?(rchien)
Priority: -- → P3
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
blocking-b2g: 2.5? → 2.5+
Target Milestone: --- → 2.6 S8 - 2/26

  

  



    
    

    
  
Comment on attachment 8721894 [details] [review]
[gaia] rickychien:show-hint-after-load > mozilla-b2g:master

Luke, it's a simple patch for triggering showPreviewHint in iframe's load event.

  

  



        Attachment #8721894 -
        Flags: review?(lchang)

    
    

    
  
Comment on attachment 8721894 [details] [review]
[gaia] rickychien:show-hint-after-load > mozilla-b2g:master

Please see my comment on GitHub. Thanks.

  

  



        Attachment #8721894 -
        Flags: review?(lchang)

    
    

    
  
Comment on attachment 8721894 [details] [review]
[gaia] rickychien:show-hint-after-load > mozilla-b2g:master

You're awesome Luke! 

As you said, the best way is to listen "_loaded" event and it makes patch more simple.

  

  



        Attachment #8721894 -
        Flags: review?(lchang)

    
    

    
  
Comment on attachment 8721894 [details] [review]
[gaia] rickychien:show-hint-after-load > mozilla-b2g:master

It's good now.

  

  



        Attachment #8721894 -
        Flags: review?(lchang) → review+

    
    

    
  
Landed:

https://github.com/mozilla-b2g/gaia/commit/550c5abe7d84563f48f777faa43aaedd2b472cc6

  

  


Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8721894 [details] [review]
[gaia] rickychien:show-hint-after-load > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none, it was merely an UX improvement
[User impact] if declined: minor
[Testing completed]: verified manually on local simulator
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

  

  



        Attachment #8721894 -
        Flags: approval-gaia-v2.5?
Flags: needinfo?(jocheng)

    
    

    
  
Comment on attachment 8721894 [details] [review]
[gaia] rickychien:show-hint-after-load > mozilla-b2g:master

Approve for TV 2.5

  

  


Flags: needinfo?(jocheng)

        Attachment #8721894 -
        Flags: approval-gaia-v2.5? → approval-gaia-v2.5+

    
    

    
  
This issue is fixed on v2.6 latest build.
The hint will show after the app finish loading.
[Build Info]
gaia:
https://github.com/mozilla-b2g/gaia/commit/1ad93502b639e5c335c15c97882a4c516b2ffa23
gecko:
https://hg.mozilla.org/mozilla-central/rev/c1e0d1890cfee9d86c8d566b0490053f21e0afc6

  

  



          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: