FTU Panel needs integration testing in a mochitest

RESOLVED INCOMPLETE

Status

P1
normal
Rank:
22
RESOLVED INCOMPLETE
3 years ago
2 years ago

People

(Reporter: standard8, Assigned: dcritchley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-fix-now][47])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Not having a test here caused us to miss the fact the FTU panel was broken when merging (bug 1249551).

We should get a mochitest added so this doesn't happen again.

The test should at a minimum:

- Ensure the pref is set to the default value.
- Open up the panel
- Ensure the FTU is displayed
- Click the button to open the tour
- Close the tour
- Open the panel, check the rooms view is displayed.
(Reporter)

Comment 1

3 years ago
Putting as a P1 as this caused us bustage in doing release that we should have avoided.
Rank: 15
Priority: -- → P1
Whiteboard: [bbtpp-fix-now]
(Reporter)

Updated

3 years ago
Rank: 15 → 12
Whiteboard: [bbtpp-fix-now] → [btpp-fix-now]
(Reporter)

Comment 2

3 years ago
Just to clarify, we need this to be an integration test.
Summary: FTU Panel needs testing in a mochitest → FTU Panel needs integration testing in a mochitest
(Reporter)

Comment 3

3 years ago
Note: Following bug 1248895 the panel is opening automatically at the end of the tour, so this will need to be taken into account when implementing the steps in comment 0.
Depends on: 1248895
(Assignee)

Updated

3 years ago
Assignee: nobody → dcritchley
Created attachment 8728100 [details] [review]
[loop] daveccrit:1250107-FTUPanelMochitests > mozilla:master
(Assignee)

Updated

3 years ago
Attachment #8728100 - Flags: review?(standard8)
(Reporter)

Comment 6

3 years ago
Comment on attachment 8728100 [details] [review]
[loop] daveccrit:1250107-FTUPanelMochitests > mozilla:master

Unfortunately try server showed almost perma fails for this, e.g.

https://treeherder.mozilla.org/logviewer.html#?job_id=17789350&repo=try

Looking at the screenshots, it looks like the tour doesn't actually get closed. I haven't thought about why that might be yet, but I guess there's a couple of options: the tour hasn't fully loaded, or something is going wrong with the click on that element.
Attachment #8728100 - Flags: review?(standard8)

Updated

3 years ago
Blocks: 1248604
(Reporter)

Comment 9

3 years ago
Given the issues, this isn't super critical for the 1.2 release, but I'd like it fixed asap after if we can.
No longer blocks: 1248604
Rank: 12 → 20
Priority: P1 → P2
(Reporter)

Comment 10

3 years ago
In the vague hope the intermittent has gone away, I'm attempting a re-push on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63089c1332a8
(Reporter)

Comment 11

3 years ago
Ok, tests are still failing:

http://archive.mozilla.org/pub/firefox/try-builds/mbanner@mozilla.com-63089c1332a82a313d2e85360722a40382fed896/try-linux64-debug/

Thoughts:

- Check the panel is actually closed
- Maybe see if logging if the open command for the panel is called.

Dave, maybe you can work on this with Dan?
Flags: needinfo?(dmose)
Flags: needinfo?(dcritchley)
(Reporter)

Updated

3 years ago
Rank: 20 → 11
Priority: P2 → P1
Whiteboard: [btpp-fix-now] → [btpp-fix-now][47]
(Assignee)

Updated

3 years ago
Flags: needinfo?(dcritchley)
Attachment #8728100 - Flags: review?(standard8)
(Reporter)

Updated

3 years ago
Flags: needinfo?(dmose)
(Reporter)

Comment 13

3 years ago
Comment on attachment 8728100 [details] [review]
[loop] daveccrit:1250107-FTUPanelMochitests > mozilla:master

I triggered a few retries of the try build, and came across this intermittent still there:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78839e4707e3dd9a4591c6264f854675f5db947d

https://treeherder.mozilla.org/logviewer.html#?job_id=19781675&repo=try

 02:42:30     INFO -  327 INFO Entering test bound test_mozLoop_close_tour
 02:42:30     INFO -  328 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_ftu.js | should have opened the panel after closing the tour -
 02:42:30     INFO -  Stack trace:
 02:42:30     INFO -  chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/head.js:waitForCondition/interval<:78
 02:42:30     INFO -  Not taking screenshot here: see the one that was previously logged
 02:42:30     INFO -  329 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_ftu.js | should have closed the tour -
 02:42:30     INFO -  Stack trace:
 02:42:30     INFO -      chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_ftu.js:test_mozLoop_close_tour:83
 02:42:30     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23

Although its seems to be greatly reduced, I'm not sure we should drop this in unless we can be reasonably sure we've got a fix for this issue.
Attachment #8728100 - Flags: review?(standard8)
(Assignee)

Comment 14

3 years ago
As per conversation, reminder to have a look at this on monday
Flags: needinfo?(standard8)
Rank: 11 → 22
(Reporter)

Updated

2 years ago
Flags: needinfo?(standard8)
(Reporter)

Comment 16

2 years ago
Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.