Closed
Bug 1250141
Opened 6 years ago
Closed 6 years ago
Remove NS_WARN_IF after AppendOriginNoSuffix in DOMStorageManager::CheckStorage
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
Attachments
(1 file)
|
873 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
It's a legal failure for about:blank that doesn't have a domain.
|
Assignee | |
Comment 1•6 years ago
|
||
- we call this method on more than one place and don't warn failures on them as well - it's perfectly legal if the origin cannot be built for some edge cases like about:blank
Attachment #8721994 -
Flags: review?(ehsan)
|
||
Updated•6 years ago
|
Attachment #8721994 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f797f47e312
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1f797f47e312
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•3 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•