1251026 - Loading a YouTube video or GitHub page triggers many lines of WARNING: 'NS_FAILED(rv)', file dom/storage/DOMStorageManager.cpp, line 454

Status: RESOLVED DUPLICATE of bug 1250141

(Core :: DOM: Device Interfaces, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Start a debug build from the terminal. (fresh profile)
 2. Visit https://www.youtube.com/embed/C4qgAaxB_pc
 3. Look at your terminal.

ACTUAL RESULTS: 42 copies of this line are spammed to your terminal:
> WARNING: 'NS_FAILED(rv)', file dom/storage/DOMStorageManager.cpp, line 454

This is from the NS_WARN_IF that was added here:
http://hg.mozilla.org/mozilla-central/diff/35794bec70ba/dom/storage/DOMStorageManager.cpp#l1.367
for bug 1165214.

Comment 1

[Daniel Holbert [:dholbert]]

A bit more info, from gdb:
 - rv is NS_ERROR_UNEXPECTED here (i.e. AppendOriginNoSuffix is returning NS_ERROR_UNEXPECTED).
 - That's because aPrincipal->GetURI returns nullptr in its outparam, here:
http://hg.mozilla.org/mozilla-central/annotate/d848a5628d80/dom/storage/DOMStorageManager.cpp#l136

 - That's because aPrincipal is an instance of nsSystemPrincipal, which always returns nullptr from GetURI.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: backtrace of call to AppendOriginNoSuffix, when it returns NS_ERROR_UNEXPECTED due to having a null uri

Here's the backtrace when this happens, FWIW.

Comment 3

[Daniel Holbert [:dholbert]]

I can reproduce this on some GitHub pages, too -- e.g. if I load this view of a storage-related repo...
 https://github.com/mdn/web-storage-demo
...I get 7 instances of this warning.