Closed
Bug 1250208
Opened 9 years ago
Closed 9 years ago
[coverity] Call to super in ToolbarEditLayout
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1250144
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
|
58 bytes,
text/x-review-board-request
|
Details |
*** CID 123515: Class hierarchy inconsistencies (CALL_SUPER)
/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarEditLayout.java: 81 in org.mozilla.gecko.toolbar.ToolbarEditLayout.onAttachedToWindow()()
75
76 mVoiceInput = (ImageButton) findViewById(R.id.mic);
77 mQrCode = (ImageButton) findViewById(R.id.qrcode);
78 }
79
80 @Override
>>> CID 123515: Class hierarchy inconsistencies (CALL_SUPER)
>>> Missing call to "org.mozilla.gecko.widget.themed.ThemedLinearLayout.onAttachedToWindow()" (as is done elsewhere 2 out of 3 times).
81 public void onAttachedToWindow() {
82 if (HardwareUtils.isTablet()) {
83 mSearchIcon.setVisibility(View.VISIBLE);
84 }
85
86 mEditText.setOnFocusChangeListener(new OnFocusChangeListener() {
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/35845/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35845/
Attachment #8722058 -
Flags: review?(s.kaspari)
|
||
Comment 2•9 years ago
|
||
I got the same review request twice in the last hour. Bug 1250144 was a bit faster. :)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
|
|
||
Updated•9 years ago
|
Attachment #8722058 -
Flags: review?(s.kaspari)
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•