1250325 - Investigate whether GeckoSmsManager closes its Cursors

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

createThreadCursor adds the Cursors to a HashMap [1], but the Cursors don't get closed when they're removed [2] from the queue. It's possible the calling code closes it (it's native so I haven't checked it).

imo, it'd be better to get the data from the Cursor, close it, and add the data to the queue in order to avoid keeping open these references to Cursors and potentially leaking them.

Snorp, do you know who'd be best to look into this?

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/GeckoSmsManager.java#1107
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/GeckoSmsManager.java#247

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

SMS code should be for webapps which is no longer in product.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, we never added the SMS permission, so this isn't used in Fennec. We've thought about turning it on for 6.0+ devices, though.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.