1153560 - Remove WebSMS code from Fennec

Status: RESOLVED DUPLICATE of bug 1310027

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

There was broad consensus in the Friday frontend meeting, as we discussed pruning our build flags, that we should remove anything conditional on MOZ_WEBSMS_BACKEND from Fennec.

We don't ship it, it doesn't work (Bug 809916), and there's probably some unconditional stuff that ends up in the build. Unless we have a strong case for turning it on soon, we should go hog-wild with the delete key.

Brad, gcp: do you have any objections?

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

NI for comment 0.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

I'm all for deleting code.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

The plan to make this functionality available is the permissions marshaling. That said, this is why we have version control. Go ahead and delete if permissions marshaling ever becomes a reality, snorp can resurrect the WebSMS implementation.

Comment 4

[Richard Newman [:rnewman]]

JFC, apparently SMS handling is deeply intertwined with PContent and the rest of DOM and layout, because literally every single thing we ship in Gecko lives in a single module, and nobody thought of conditionalizing when it was landed. Aiee.

I've spent a surprising amount of time liberally sprinkling ifdefs around, and finally ended up with an unconditional inclusion of PSms in PContent.ipdl which I can't be bothered to fix right now. So lemme see if I can just upload the Java-only patch, and we can kill a ton of code from dom/ later.

Comment 5

[Richard Newman [:rnewman]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b74ca602c3

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to Richard Newman [:rnewman] from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b74ca602c3

Where's the patch for that ?

Comment 7

[Makoto Kato [:m_kato]]

WebSMS was removed by bug 1310027.