1250404 - [TV][Marketplace] Visual polish for "Web App" icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Tori Chen [:tori]]

Current design on big screen looks little monotonous and not horizontally center aligned.

Comment 1

[Helen Huang [:HHuang]]

Attachment: Web_Apps_modified.png

I tried to modify the background color of Web Apps icon and made the rocket a bit smaller. The gradient color is following the guideline (https://www.mozilla.org/en-US/styleguide/identity/firefoxos/color/). Please take a look at the visuals.

Comment 2

[Helen Huang [:HHuang]]

Attachment: Web_Apps_current.png

Attached current Web Apps icon for reference.

Comment 3

[Tori Chen [:tori]]

Joe, can you take a look on this?

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

ni? David & Niran
looks fine to me

Comment 5

[David Bialer [:dbialer]]

looks great to me.

Comment 6

[Josh Cheng [:josh]]

Hi Joseph,
Please handle this bug. Thanks

Comment 7

[Helen Huang [:HHuang]]

The new Web Apps icon is updated. Link here: http://bit.ly/1THJwK8

Comment 8

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1250404 > mozilla-b2g:master

Comment 9

[Joseph Yeh [:joseph]]

Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/fd7d73835506b911a56f138937a6e7a1b516c758


Still need another patch for gaia in order to update the app icon.
Will be done after the updated icon is serving on the production server.

Comment 10

[[e-mail]]

looks OK

Comment 11

[Evelyn Hung]

(In reply to Joseph Yeh from comment #9)
> Landed in marketplace-tv-front-end master.
> 
> https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/
> fd7d73835506b911a56f138937a6e7a1b516c758
> 
> 
> Still need another patch for gaia in order to update the app icon.
> Will be done after the updated icon is serving on the production server.

Will you do it in a follow-up bug and close this one, or you prefer using this bug?

Comment 12

[Joseph Yeh [:joseph]]

I prefer using this bug since this is already in Gaia::TV.

Comment 13

[Evelyn Hung]

Joseph, any update here? Per you comment 9, is the icon on production server already?

Comment 14

[Joseph Yeh [:joseph]]

I don't know why they miss this on last week's release :(

I'll ping them on IRC to make sure it lands on production this week.

Comment 15

[Josh Cheng [:josh]]

Hi Joseph,
Any update?

Comment 16

[Joseph Yeh [:joseph]]

As mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1254420#c3 , the production server will not be update until March 29. If QA need to test anything, please check it on the dev server. Thanks.

Comment 17

[GitHub Autolander Bot]

Attachment: [gaia] jostw:josyeh/Marketplace/master/Bug1250404 > mozilla-b2g:master

Comment 18

[Joseph Yeh [:joseph]]

Comment on attachment 8732048 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1250404 > mozilla-b2g:master

Hi Rex, this patch simply just replace the icon of Web Apps with the updated version. Since the production server did not update yet, I replace the icon manually.

Please take a look, thanks!

Comment 19

[Joseph Yeh [:joseph]]

Landed in gaia master.

https://github.com/mozilla-b2g/gaia/commit/e5098978adae8750f013d96a825820f75b4054ac

Comment 20

[Joseph Yeh [:joseph]]

Comment on attachment 8732048 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1250404 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1250404
[User impact] if declined: No new Web Apps icon 
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No

Comment 21

[Josh Cheng [:josh]]

Comment on attachment 8732048 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1250404 > mozilla-b2g:master

Approve for TV 2.5

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] jostw:v2.5 > mozilla-b2g:v2.5

Comment 23

[Joseph Yeh [:joseph]]

Uplift to gaia v2.5

https://github.com/mozilla-b2g/gaia/commit/211ddf230c78526b1b93b33b00834d816a10f70e