1250650 - disable mozpayment tests android

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Payments, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we have mozpayment tests running on b2g/mulet/android, we don't need them on android.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: MozReview Request: Bug 1250650 - disable mozpayment tests android. r?fabrice

Review commit: https://reviewboard.mozilla.org/r/36155/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36155/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

here is the try run which is looking good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3213434046b

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8722635 [details]
MozReview Request: Bug 1250650 - disable mozpayment tests android. r?fabrice

https://reviewboard.mozilla.org/r/36155/#review32973

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea3d2ad1b20c

Comment 5

[Peter Van der Beken [:peterv]]

We should not disable tests for code that we ship. Either the payment code should be disabled on Android (with the test) or the test needs to stay. Disabling just the test is wrong.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

:fabrice, do you have other thoughts here?  I am fine enabling the test again- maybe understanding the current state and future state as well as how it is used on android would help.

Comment 7

[[:fabrice] Fabrice Desré]

Right, let's also disable the API on android. You can double check with the Mobile team, but I'm 99.9% sure that this was only used for paid apps from the Marketplace and we removed apps support from Android.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

:mfinkle, can you comment on the moz payment api and android?  Is this being used?  If so is this something we should leave in the code base on trunk?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Fabrice is correct. MozPay is Marketplace apps only and we are removing those. I'd like to see it removed.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea3d2ad1b20c

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

I see a lot of code added in bug 813756.  This is partially covered by:
https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile+mozpay&redirect=false&case=false

:wesj, I see you had written this code originally, to remove mozpay, should we just remove code which is referenced above?

Comment 12

[:Margaret Leibovic]

(In reply to Joel Maher (:jmaher) from comment #11)
> I see a lot of code added in bug 813756.  This is partially covered by:
> https://dxr.mozilla.org/mozilla-central/
> search?q=path%3Amobile+mozpay&redirect=false&case=false
> 
> :wesj, I see you had written this code originally, to remove mozpay, should
> we just remove code which is referenced above?

I don't know if wesj still look at bugmail, but I assume we can effectively back out bug 813756 to remove this feature (as well as anything else that matches the "mozpay" search). We should file a separate bug about this.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

clearing old needinfo!