1250793 - "Assertion failure: aContainer (Must have parent here)" with createShadowRoot

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: aContainer (Must have parent here), at layout/base/nsCSSFrameConstructor.cpp:4857

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Andrew Overholt [:overholt]]

William, what do you think?

Comment 3

[Andrew Overholt [:overholt]]

William will look at this after his patches for the new Shadow DOM API land.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Tested with the webcomponents pref enabled and Stylo disabled.

Fix range:
INFO: First good revision: 08cec1c29418b33a27fc254c884494fb5cced0dd
INFO: Last bad revision: 846d96d2edb40886b016b3d1a478c3a7389c9c4d
INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=846d96d2edb40886b016b3d1a478c3a7389c9c4d&tochange=08cec1c29418b33a27fc254c884494fb5cced0dd

Fixed by bug 1331322. NI myself to land the test.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ebddc587c82
Add crashtest. r=me

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing own crashtest: 

https://hg.mozilla.org/integration/autoland/rev/07c86adc1b5f6775a37f4f1686c81426112c1a04

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=10ec88e1aa4e737f61b8199a34327bd8be4a1a76&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=138487175&repo=autoland

Assertion failure: content->GetFlattenedTreeParentNodeForStyle() == &aContent, at z:/build/build/src/layout/base/ServoRestyleManager.cpp:1220
Assertion failure: !pd->minidump, at z:/build/build/src/toolkit/crashreporter/nsExceptionHandler.cpp:3430
TEST-UNEXPECTED-FAIL | file:///Z:/task_1508505456/build/tests/reftest/tests/layout/base/crashtests/1250793.html | application terminated with exit code 1
REFTEST PROCESS-CRASH | file:///Z:/task_1508505456/build/tests/reftest/tests/layout/base/crashtests/1250793.html | application crashed [@ mozilla::VerifyFlatTree]
REFTEST PROCESS-CRASH | file:///Z:/task_1508505456/build/tests/reftest/tests/layout/base/crashtests/1250793.html | application crashed [@ mozilla::VerifyFlatTree]
REFTEST PROCESS-CRASH | file:///Z:/task_1508505456/build/tests/reftest/tests/layout/base/crashtests/1250793.html | application crashed [@ CrashReporter::OnChildProcessDumpRequested]

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Well that's disappointing.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Never ceases to amaze me too - I did 50 crashtest runs across every platform on Try before pushing this and didn't see this happen once.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Hah, that's because Emilio added that assert yesterday in bug 1409088!

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Well, glad it's catching bugs :)

This bug is because HTMLVideoElement also contains an XBL binding, I think, so we mess up the flattened tree somehow... probably we should just ban shadow root in HTMLVideoElement, or something like that...

Comment 11

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 12

[Intermittent Failures Robot]

2 failures in 735 pushes (0.003 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 2

Platform breakdown:
* windows10-64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1250793&startday=2018-01-29&endday=2018-02-04&tree=all

Comment 13

[Emilio Cobos Álvarez (:emilio)]

AttachShadow doesn't support <video>, and createShadowRoot is gone from the spec.