Closed
Bug 1250832
Opened 8 years ago
Closed 7 years ago
Remove devtools globals from browser.xul
Categories
(DevTools :: General, defect, P2)
DevTools
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: [btpp-fix-later])
Attachments
(2 files)
3.80 KB,
patch
|
Details | Diff | Splinter Review | |
59 bytes,
text/x-review-board-request
|
jryans
:
review+
|
Details |
Here is the current list of globals: gDevTools, gDevToolsBrowser, HUDService: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#7544 ScratchPad, ResponsiveUI, EyeDropper: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#7616 DeveloperToolbar, BrowserToolboxProcess: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#160 Most of them are used to implement hardcoded menus. Once we insert menus dynamically (bug 124860), we won't need these globals. None of browser code actually use any of these globals. But I would have to check for any of them if some addons are using them. So we will most likely keep some for compatiblity, like gDevTools.
Assignee | ||
Comment 1•8 years ago
|
||
I opened bug 1250833 in order to stop using these globals from devtools codebase.
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc22b1065093
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0813c2922a34
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=11d3a3a72030
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e57a0be4b1ec
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c9c59f72b81
Priority: -- → P2
Whiteboard: [btpp-fix-later]
Assignee | ||
Comment 8•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ae1599eaa70
Assignee | ||
Comment 9•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6862b94fbc6c
The `ResponsiveUI` bit can surely be removed now, since the lazy getter was already removed in bug 1399449.
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8911806 [details] Bug 1250832 - Remove DevTools globals from browser.xul scope. https://reviewboard.mozilla.org/r/183232/#review188466 Thanks for the cleanup! :) ::: browser/base/content/browser.js:8562 (Diff revision 1) > gBrowser.selectedTab = newTab; > break; > } > } > > var Scratchpad = { I believe this `var Scratchpad` should also be removed.
Attachment #8911806 -
Flags: review?(jryans) → review+
Comment hidden (mozreview-request) |
Comment 14•7 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/418e79946237 Remove DevTools globals from browser.xul scope. r=jryans
Comment 15•7 years ago
|
||
Backed out for failing devtools/client/commandline/test/browser_cmd_csscoverage_startstop.js on Windows 7 debug: https://hg.mozilla.org/integration/autoland/rev/d4a29741c62807f145203dc5689cb74bfbd83daa Push which ran failing test: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f8b6f4681fb8830cbdb904c0ee77313ebfebc31e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=133305665&repo=autoland > TEST-UNEXPECTED-FAIL | devtools/client/commandline/test/browser_cmd_csscoverage_startstop.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/commandline/test/browser_cmd_csscoverage_startstop.js:53 - ReferenceError: gDevTools is not defined
Flags: needinfo?(poirot.alex)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 17•7 years ago
|
||
Green try on windows: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5c3702943e515f7a9f621f06549752f8b8dd913
Flags: needinfo?(poirot.alex)
Comment 18•7 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ab65f749652 Remove DevTools globals from browser.xul scope. r=jryans
Comment 19•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5ab65f749652
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•