Closed
Bug 1250983
Opened 9 years ago
Closed 8 years ago
Add mochitest to ensure the "Forget" button correctly deletes all data from all user contexts.
Categories
(Core :: DOM: Security, defect, P2)
Core
DOM: Security
Tracking
()
RESOLVED
DUPLICATE
of bug 1270338
People
(Reporter: huseby, Assigned: jhao)
References
Details
(Whiteboard: [userContextId] btpp-active [domsecurity-backlog2][OA-testing][tor-testing])
The Forget button is designed to delete all cached data stored in the most recent X amount of time. It needs to delete all cached data stored in all user contexts. This bug is for writing tests and investigating that it behaves correctly.
Updated•9 years ago
|
Whiteboard: [userContextId] → [userContextId] btpp-active
Updated•9 years ago
|
Component: DOM → DOM: Security
Updated•9 years ago
|
Whiteboard: [userContextId] btpp-active → [userContextId] btpp-active [domsecurity-active]
Is this different from Bug 1238183?
Flags: needinfo?(huseby)
Comment 4•9 years ago
|
||
This bug is for the "forget" button that forgets about all sites in all user contexts for the last X minutes.
This is different than bug 1238183, which is about forgetting all data about a particular site instead of forgetting data about all sites within a certain time frame.
Flags: needinfo?(huseby)
| Reporter | ||
Updated•9 years ago
|
Assignee: huseby → nobody
Updated•9 years ago
|
Whiteboard: [userContextId] btpp-active [domsecurity-active] → [userContextId] btpp-active [domsecurity-active][OA]
Updated•9 years ago
|
Priority: -- → P1
Updated•9 years ago
|
Assignee: nobody → tihuang
Comment 5•9 years ago
|
||
Kamil, can you test how the Forget button behaves now? If you are logged into an account with your work context, then hit the forget button, are you still logged into the account in your work context?
Flags: needinfo?(kjozwiak)
Comment 6•9 years ago
|
||
It looks like the Forget button is correctly removing everything, including anything that was loaded in a container. I tested this for around 3-4 hours and didn't run into any issues of data being left behind once the forget button was used.. Went through the following test cases:
* logged into several different websites using all four containers and instantly selected "forget five minutes"
* logged into several different websites using all four containers and waited 5 minutes
** ensured I was still logged into all the websites once selecting "forget five minutes"
** ensured everything was removed once I selected "forget two hours"
* logged into several different websites using all four containers and waited 2 hours
** ensured I was still logged into all the websites once selecting "forget five minutes"
** ensured I was still logged into all the websites once selecting "forget 2 hours"
** ensured everything was removed once I selected "forget 24 hours"
I also tried different combinations of having several containers in a separate window, and several containers in the same window.
Once the "Forget" button was pressed, I went through the following and ensured everything was cleared:
* Cookies under about:preferences#privacy were removed
* Cache under about:cache was being removed
* History is being removed
Flags: needinfo?(kjozwiak)
As per email discussion, since this seems to be working as intended we can move this to a oa-testing bug, drop priority to p2 and focus on others first.
Priority: P1 → P2
Whiteboard: [userContextId] btpp-active [domsecurity-active][OA] → [userContextId] btpp-active [domsecurity-active][OA-testing]
Updated•9 years ago
|
Summary: Make sure the "Forget" button correctly deletes all data from all user contexts. → Add mochitest to ensure the "Forget" button correctly deletes all data from all user contexts.
Updated•9 years ago
|
Assignee: tihuang → nobody
Whiteboard: [userContextId] btpp-active [domsecurity-active][OA-testing] → [userContextId] btpp-active [domsecurity-backlog][OA-testing]
Updated•9 years ago
|
Priority: P2 → P3
Whiteboard: [userContextId] btpp-active [domsecurity-backlog][OA-testing] → [userContextId] btpp-active [domsecurity-backlog2][OA-testing]
Updated•9 years ago
|
Priority: P3 → P2
Updated•9 years ago
|
Whiteboard: [userContextId] btpp-active [domsecurity-backlog2][OA-testing] → [userContextId] btpp-active [domsecurity-backlog2][OA-testing][tor-testing]
| Assignee | ||
Comment 8•8 years ago
|
||
I uploaded a test patch in bug 1270338 to ensure a Sanitizer cleans up cookies of every origin attributes. This bug could be a duplicate of that one.
Assignee: nobody → jhao
Depends on: 1270338
| Assignee | ||
Comment 9•8 years ago
|
||
Here's where the forget button uses the Sanitizer.
http://searchfox.org/mozilla-central/rev/5ee2bd8800b007d6c120d9521d5bf01131885afb/browser/components/customizableui/CustomizableWidgets.jsm#1215-1218
| Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•