125107 - File Bookmark: creating a new folder should select it

Status: RESOLVED EXPIRED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Right-cilck a link and select "File Bookmark for Link...".
2. Create a new folder using the "New Folder..." button in the dialog.

Result: the new folder is added but not selected.  If I hit "OK" at this point,
the new bookmark lands in the root bookmarks folder.

Expected: the new folder should be selected.

Comment 1

[Chris Lyon]

Looks like bug 44813 (but in a different dialog)

Comment 2

[Pete Zha]

Attachment: Patch (v1)

new Created folder is in newFolderRDFObserver, so just get it and select it.
This patch also fix newFolder in bookmark manager page

Comment 3

[Pete Zha]

cc blaker

Comment 4

[Pete Zha]

hm... cc [e-mail]. He give me r= on bug 44813 and can review this one.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I won't get to this till next wednesday, so you may want to find a different
reviewer...

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Does this work? I was aware that we're not storing rdf:type info for bookmarks
or folders anymore. 

Comment 7

[Pete Zha]

I tested it on trunk build20020403. It works fine. Is there any change after 
that day? 
I will test it in today's build.

Comment 8

[Pete Zha]

I have tested it on today's build and it works fine for me.

Comment 9

[Pete Zha]

Sorry for confusing comments above.
I meant in today's build and with this patch, I can see the new created folder 
is selected after create it.

Comment 10

[Andreas Kunz]

What about this patch?
Still works?
As far as I can tell, this bug is still alive in bookmarks/file bookmark(but not
with right click anymore, because the context menu got changed).

Comment 11

[Andy Edmonds]

Indeed, this bug is still alive in file bookmark.  Adding keyword haspatch --
can't test it at this moment.

This is especially bad when the target folder is large enough for the new folder
to be offscreen, requiring an expensive MOUSEMOVE-MOUSEDOWN-MOUSEMOVE-MOUSEUP
and a MOUSEMOVE-MOUSECLICK versus the unnecessary MOUSEMOVE-MOUSECLICK that's
necessitated by the lack of this behavior.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Removing bogus blocking flag.

Comment 13

[Hungerburg]

hello,

I was asked to review above patch; but I cant find the file in neither
application folder nor private .folder. would I have to install the sources?

running moz firebird of 2/3 days ago, new folders are not hilited after create,
in the bookmarks manager, so the bug exists here too.

regards,

pch.

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

bz: I think you picked the wrong pch...

Comment 15

[Pierre Chanial]

Comment on attachment 77411 [details] [diff] [review]
Patch (v1)

that's funny.
Funniest is that bookmarks.xml doesn't exist anymore.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Any chance of porting this fix to whatever _does_ exist that has the same bug?  

Comment 17

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 18

[cdq]

I cannot reproduce this in Firefox 3.0.11/Win32 as follows:

1) Right-click on a link
2) Choose Bookmark This Link...
3) Click the New Folder button

Result: New folder created, selection jumps to new folder.

Comment 19

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420