***Overview Description: This is an offshoot of bug 27040. When you create a new bookmark it needs to be selected. Otherwise it is often difficult to find your newly created bookmark. ***Steps to Reproduce: 1) Open Manage Bookmarks window. 2) Select File|New. 3) Give your new bookmark a url and title. ***Actual Results: Your new bookmark is created at your previous selection point or at the top of your tree. But with no visual indication. ***Expected Results: The new bookmark is created and hilighted so i know where to findit and can immediately begin to manipulate it if I so choose. ***Build Date & Platform Bug Found: All platforms with the 2000070708 builds
Reassigning 79 Bookmarks bugs to Ben. I was told this was going to be done shortly about two months ago, but it clearly hasn't been. I think that's long enough for all these bugs to remain assigned to nobody. Feel free to filter all this spam into the trashcan by looking for this string in the message body: ducksgoquack
Netscape Nav triage team: this is not a Netscape beta stopper, but would be nice to have. adding helpwanted keyword.
This still happens in the new bookmarks manager window. Please note that new folders are created inline but the window does not scroll to their location. I reported that in another bug, as part of my hunt for bugs in the new bookmarks manager.
Marking nsbeta1- bugs as future to get off the radar.
16 years ago
Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter email notifications caused by this by searching for 'ilikegoats'.
Hi, paul: Since this bug is helpwanted, what's more, I want to contribute my work to Mozilla community, would you please assign this bug to me? I would like to have a try, I think I would have a good starting with the help from you and email@example.com, who is the module owner of OJI. As a freshman of Mozilla community, I do not know whether it is suitable to ask you to assign a bug to a freshman directly, if not, please feel free to tell me the reasonable way, it would be very helpful for me. Thanks a lot. Jay yan
Add myself to the cc list.
Jay Yan is taking this bug now -> firstname.lastname@example.org
Two pathces can fix this bug: 1 Add a function 'selectFolderLastItem' in file bookmarksTree.js, this function hilights the last bookmark item in current folder. 2 Call above function after execCommand("newfolder") in file bookmarksOverlay.js Basic test has been done without exception, after detailed test is finished, I will apply for source CheckIn.
Add email@example.com to CC list.
Created attachment 60150 [details] The diff file of bookmarksTree.js It is one diff file, there is another one diff file for this solution. This diff file shows how to add a function which can hilight the last item of current folder
Created attachment 60151 [details] It is the diff file for bookmarksOverlay.js This diff file shows how to call the function 'selectFloderLastItem' to hilight a new bookmark after a new bookmark is created.
This patch needs improvement. 1 We do not have to loop to get last item of one folder, we can use attribute 'lastchild' directly. 2 It is unsuitable to always hilight the last item, if the sorting order is changed, this logic is wrong. We are modifying it.
Created attachment 60482 [details] To fix this bug, more simple I think See the attachment... I use function 'selectFolderItem' of gBookmarksShell object to do the item select behavior. I tested it on Windows build (Milestone096). Will do more test on Solaris and Linux...
Jay/Pete: Please test it with the trunk. In order to get it reviewed and checked in, we'll need to have it tested with the trunk. If it works in the trunk as well, then please attach the diff file for the trunk. Margaret
Pete got a better way to fix this bug, reassign this bug to Pete.
Created attachment 60629 [details] Diff between my fix to mozilla trunk If we don't have a protocol scheme, add "http://" as a default scheme...
firstname.lastname@example.org: Can you review Pete's last patch please? Thanks.
Created attachment 61199 [details] Diff between trunk on 11/12/2001 Add condition to test whether the 5th argument is null. More safe if other codes invoke this function without 5th argument.
Hi, email@example.com We have tested this patch on Tier-one platforms and Solaris, can you review it now? Thanks. Jay/Pate
Can someone review the patch please?
16 years ago
Comment on attachment 61199 [details] Diff between trunk on 11/12/2001 r/sr=bz/shaver. bz to commit with change to avoid strict warning if no 6th argument is passed.
This comment here in protest of fascist bugzilla settings.
Comment on attachment 61199 [details] Diff between trunk on 11/12/2001 Actually, I'm rescinding review. I just tested this and it does not work... Most likely the bookmarks outliner changes broke it. The code that gets called to add the bookmark using the steps to reproduce listed here now lives in bookmarks.xml, and gBookmarksShell is never set to anything but null that I can tell.... Jay, would you be willing to update the patch?
Back to Pete. Our apologies for review being so slow.... ccing self so it doesn't happen again. :)
Yes, I will update the patch later.
See also bug 125107, creating a folder in File Bookmark dialog (in the brwoser) should select the new folder.
Created attachment 77020 [details] [diff] [review] New patch with trunk
Created attachment 77022 [details] [diff] [review] Use "rv" to return new created bookmark. Could be more simple than last one.
both patches look fine to me... r=bzbarsky on either one (assuming you tested and this works, of course)
Yes, I have tested on trunkbuild20020401 Windows2000
cc to blaker.
Comment on attachment 77022 [details] [diff] [review] Use "rv" to return new created bookmark. sr=blake
Comment on attachment 77022 [details] [diff] [review] Use "rv" to return new created bookmark. bzbarsky, add your r= here, is this ok? r=bzbarsky
Yep, that's fine. :)
Comment on attachment 77022 [details] [diff] [review] Use "rv" to return new created bookmark. a=asa (on behalf of drivers) for checkin to the 1.0 trunk
fix checked in
VERIFIED FIXED 2002122208