125128 - Composer needs a Publish icon for main toolbar

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Charles Manske]

We will be morphing the "Save" toolbar item into "Publish" when users are
editing a remote URL. This image needs to be in a similar style to current
Composer icons, but convey saving to a web or network location.
Icons needed for Modern and Classic themes.

Comment 1

[Charles Manske]

nominating for nsbeta1

Comment 2

[David Hallowell]

*** Bug 125722 has been marked as a duplicate of this bug. ***

Comment 3

[David Hallowell]

If the print button is going to morph into a publish button it might give the
impression to people who initially started with a local file that the publish
facility is not available (at a first glance anyway).

Comment 4

[Charles Manske]

Attachment: MODERN-Primary toolbar images including a Publish button

Just a 1st draft so we can display something!
Based on 4.7 publish icon.

Comment 5

[Charles Manske]

Attachment: CLASSIC-Primary toolbar buttons including Publish button

1st draft for Classic theme

Comment 6

[Charles Manske]

Attachment: Composer themes css changes to use publish button

Comment 7

[Charles Manske]

Taking bug for themes patch and 1st draft of icons.

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 69864 [details] [diff] [review]
Composer themes css changes to use publish button

r=glazman

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 69864 [details] [diff] [review]
Composer themes css changes to use publish button

sr=dveditz

Comment 10

[Charles Manske]

Comment on attachment 69864 [details] [diff] [review]
Composer themes css changes to use publish button

checked in.

Comment 11

[Charles Manske]

checked in. Handing back to Marlon for final versions of icons

Comment 12

[Lori Kaplan]

I'm not sure what the current status of this bug is. The icon appears to be
done. Marlon, can you comment so we can add the appropriate [adt] keyword to
this bug?

Comment 13

[Charles Manske]

You like that icon? I whipped it up by copying the old one from 4.x. Blended into
the new style, but I'm sure Marlon could improve upon it!
It wasn't intended to be the final version. 
Publishing is obviously very important to Composer, so it would be nice to have
a really good icon.

Comment 14

[selmer (gone)]

Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.)  Thanks!

Comment 15

[Charles Manske]

Adding status whiteboard notation to be sure this gets ADT attention.
Since I've seen some good art for this, I know a good fix is pending!
Can we please get some samples attached here so we can evaluate them?

Comment 16

[marlon bishop]

Attachment: the new publish button (4 states)

Comment 17

[Jaime Rodriguez, Jr.]

cc'ing docs and l10n as a change like this, after the UI freeze may effect their
schedules.

Comment 18

[Charles Manske]

Umm, we can certainly live with this icon, but this is "C" in the original
suggestions and Lori said version "B" was the one accepted. "B" had many more
votes because the page graphic was more consistent with the others on the 
toolbar. This one is ok, though and I'm not suggesting we change it, but I just 
wanted to be sure our review process was noted.

BTW, is the Classic theme version ready?

Comment 19

[marlon bishop]

the review process was indeed noted, and i think that i took the votes for B
into consideration when deciding that C was the best variation.  C conveys the
'in-motion' aspect, where in B the document was 'dead' flat on a surface.  I
think that motion is important for the implied meaning behind the icon, wouldn't
you agree?

Comment 20

[Charles Manske]

Yes, I picked up on the "in motion" aspect of C, which is why I decided that it
is quite acceptable!

Comment 21

[rchen]

Approved for UI change from L10N. 

Comment 22

[Lori Kaplan]

Please check in the new publish icon. 

Comment 23

[Charles Manske]

The publishing icon is NOT a separate image, but is part of one large image in 
the themes somewhere. That integration really should be done by UE, but I'll
look into it.
The attached zip still does not have any images for Classic theme.

Comment 24

[Charles Manske]

Ok, I found the toolbar image file thanks to Joe Hewitt, so I can integrate the 
images. 
Since it seems Classic simply looks like 4.x icons, the existing publishing 
images are ok, since that's where they were taken from.

Comment 25

[Charles Manske]

Attachment: New publish images integrated into themes toolbar graphic

This is the file that needs to be checked in to update Publish icons.

Comment 26

[Charles Manske]

Comment on attachment 88403 [details]
New publish images integrated into themes toolbar graphic

r=cmanske

Comment 27

[Johnny Stenback (:jst)]

Comment on attachment 88403 [details]
New publish images integrated into themes toolbar graphic

sr=jst

Comment 28

[Charles Manske]

File "mozilla/themes/modern/editor/icons/btn1.gif" checked into trunk.

Comment 29

[michael wendell]

Verified, new icon is there.

Comment 30

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 31

[Paul Wyskoczka]

Adding adt1.0.1+ on behalf of the adt for checkin to the 1.0 branch, pending an
ok from Steve Rudman.  Please get drivers approval before checking in. When you
check this into the branch, please change the mozilla1.0.1+ keyword to fixed1.0.1

Comment 32

[Charles Manske]

checked into mozilla 1.0.1 branch

Comment 33

[Jaime Rodriguez, Jr.]

pmac - pls verify this fix on the 1.0 branch tomorrow. thanks!

Comment 34

[Patty Mac]

Verified on netscape branch build (2002-07-24-08-1.0.0)