12513 - HTMLSelectElement.options.selectedIndex not supported

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[cody]

I tested one of my complex javascript programs using the Seamonkey 1999-9-25-13
(M10) nightly build on WinNT 4.0 SP 5.  Moz can't identify the selected index
in a select form field. Code snippet you can test.

<Script Language="Javascript">
function foobar() {
  if (document.outputdebug.foobie.options.selectedIndex == 0)
    window.alert("BAM!");
}
</script>
<form name="outputdebug"><select name="foobie" size="3">
<option name="1">BAM
</select>
<input type="button" onClick="foobar();" value="DoIt">
</form>

When I clicked on option 1 and hit the DoIt button, a "BAM!" alert should pop
up (tested in ie5) but in this build, does nothing.

Comment 1

[cbegle]

wrong component

Comment 2

[Mike McCabe]

Reassigning to owner of DOM Level 0 (sorry, vidur.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I would expect "document.outputdebug.foobie.selectedIndex" to work, but not with
".options" in the middle.  For some reason, though, this does work in 4.x.  How
annoying.  I guess this should be supported somehow.

Changing title from "Form selection field selectedIndex not working properly" to
"[4.xP]HTMLSelectElement.options.selectedIndex not supported".  Since options is
an HTMLCollection, this might require some work.

Comment 4

[Eric Pollmann]

Grabbing this one.

Comment 5

[Eric Pollmann]

Moving non-critical bugs out.

Comment 6

[Eric Pollmann]

Moving to M14 see bug 16879 for reasons why.

Comment 7

[vidur (gone)]

*** Bug 23087 has been marked as a duplicate of this bug. ***

Comment 8

[Prashant Desale]

Setting seviarity to major.

Comment 9

[leger]

Setting the keyword all open [4.xp] bugs to 4xp.

Comment 10

[leger]

Putting on PDT+ radar for beta1.

Comment 11

[Eric Pollmann]

I brought the changes forward into my tree and they almost work (one bug I'm
working on in setLength for bug 16879).  Will update status later today.  

(Performance is better, but not great.)

Comment 12

[Eric Pollmann]

Fix for this bug and bug 16879 is ready.  I touched the following files (!=new)
Will need a code review (I'll hit Vidur up for one) and approval.

dom/public/idl/html/
! nsHTMLOptionCollection.idl
  nsHTMLSelectElement.idl
  makefile.win
  Makefile.in

dom/public/html/
  nsIDOMHTMLSelectElement.h
! nsIDOMNSHTMLOptionCollection.h
  makefile.win
  Makefile.in
  MANIFEST

dom/src/html/
  nsJSHTMLSelectElement.cpp
! nsJSNSHTMLOptionCollection.cpp
  Makefile.in
  makefile.win
(add to dom/macbuild/dom.mcp)

layout/html/content/src/
  Makefile.in
  makefile.win
! nsHTMLOptionCollection.cpp
! nsHTMLOptionCollection.h
  nsHTMLOptionElement.cpp
  nsHTMLSelectElement.cpp
! nsHTMLSelectElement.h
(add to layout/macbuild/layout.mcp)

layout/html/forms/src/
  nsListControlFrame.cpp

extensions/wallet/src/
  wallet.cpp

Comment 13

[Eric Pollmann]

Got a review from Vidur for this yesterday.

Comment 14

[Eric Pollmann]

Just checked in the fix.  This also fixed bug 16879.

Comment 15

[Prashant Desale]

verified with 02-29-09.