Remove the dom.serviceWorkers.interception.enabled pref

RESOLVED FIXED in Firefox 47

Status

()

Core
DOM: Service Workers
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
I'd like to do this now, since we won't go back to the state where we want to ship the API but unship the actual interception.  Any objections, Ben?
Flags: needinfo?(bkelly)

Comment 1

2 years ago
We need the pref for 45esr, but OK removing it in 47+.
Flags: needinfo?(bkelly)
Whiteboard: btpp-active
(Assignee)

Comment 2

2 years ago
Created attachment 8724894 [details] [diff] [review]
Patch (v1)
Attachment #8724894 - Flags: review?(bkelly)

Comment 3

2 years ago
Comment on attachment 8724894 [details] [diff] [review]
Patch (v1)

Review of attachment 8724894 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if it passes a try build.

Want to do a P2 patch to remove the opaque interception pref?
Attachment #8724894 - Flags: review?(bkelly) → review+

This bug 1251875, Remove the dom.serviceWorkers.interception.enabled pref, has been reviewed.

An engineer is working on this bug.

You will receive emailed updates on the progress of your bug’s fix from Bugzilla, so make sure that bugzilla-daemon@mozilla.org is not blocked in your spam filters.

Thank you.
(Assignee)

Comment 5

2 years ago
> Want to do a P2 patch to remove the opaque interception pref?

Yep, will do!
(Assignee)

Comment 6

2 years ago
Created attachment 8725041 [details] [diff] [review]
Part 2: Remove the dom.serviceWorkers.interception.opaque.enabled pref
Attachment #8725041 - Flags: review?(bkelly)

Comment 7

2 years ago
Comment on attachment 8725041 [details] [diff] [review]
Part 2: Remove the dom.serviceWorkers.interception.opaque.enabled pref

Review of attachment 8725041 [details] [diff] [review]:
-----------------------------------------------------------------

We should remove the l10n string from dom.properties, bit otherwise looks good.
Attachment #8725041 - Flags: review?(bkelly) → review+

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a83057f5e96d
https://hg.mozilla.org/mozilla-central/rev/7729ce5fd356
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Comment 10

10 months ago
Still present in Fennec nightly v57
You need to log in before you can comment on or make changes to this bug.