1251953 - Some sizes on toolbars not optimal

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

There are some sizes on toolbars which are not optimal.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: sizeTweaks.patch

The fixes are:
- Give the toolbars on left/right a 1px padding.
- Menulists on toolbars are 1px too tall.
- On Win10 they force the buttons to be taller.
- The searchfield on #ab-toolbox touches the toolbar borders and the buttons are taller than on other toolbars. Fixing by giving the searchfield the same margin as for other searchfields.

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8724562 [details] [diff] [review]
sizeTweaks.patch

Review of attachment 8724562 [details] [diff] [review]:
-----------------------------------------------------------------

FYI it's easier for me to give fast reviews with screenshots. :)

Comment 3

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/086bc4f91362

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8724562 [details] [diff] [review]
sizeTweaks.patch

[Approval Request Comment]
User impact if declined: some parts on buttons and toolbars could look too squeezed on Windows
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Kent James (:rkent)]

Comment on attachment 8724562 [details] [diff] [review]
sizeTweaks.patch

http://hg.mozilla.org/releases/comm-aurora/rev/74ad096eb846
http://hg.mozilla.org/releases/comm-beta/rev/51665c16cc72
http://hg.mozilla.org/releases/comm-esr45/rev/890dac270016