Closed Bug 1251953 Opened 4 years ago Closed 4 years ago

Some sizes on toolbars not optimal

Categories

(Thunderbird :: Theme, defect)

All
Windows
defect
Not set

Tracking

(thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed, thunderbird48 fixed)

RESOLVED FIXED
Thunderbird 48.0
Tracking Status
thunderbird45 --- fixed
thunderbird46 --- fixed
thunderbird47 --- fixed
thunderbird48 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

There are some sizes on toolbars which are not optimal.
Attached patch sizeTweaks.patchSplinter Review
The fixes are:
- Give the toolbars on left/right a 1px padding.
- Menulists on toolbars are 1px too tall.
- On Win10 they force the buttons to be taller.
- The searchfield on #ab-toolbox touches the toolbar borders and the buttons are taller than on other toolbars. Fixing by giving the searchfield the same margin as for other searchfields.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8724562 - Flags: review?(clokep)
Comment on attachment 8724562 [details] [diff] [review]
sizeTweaks.patch

Review of attachment 8724562 [details] [diff] [review]:
-----------------------------------------------------------------

FYI it's easier for me to give fast reviews with screenshots. :)
Attachment #8724562 - Flags: review?(clokep) → review+
http://hg.mozilla.org/comm-central/rev/086bc4f91362
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
Comment on attachment 8724562 [details] [diff] [review]
sizeTweaks.patch

[Approval Request Comment]
User impact if declined: some parts on buttons and toolbars could look too squeezed on Windows
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8724562 - Flags: approval-comm-esr45?
Attachment #8724562 - Flags: approval-comm-beta?
Attachment #8724562 - Flags: approval-comm-aurora?
You need to log in before you can comment on or make changes to this bug.