1251999 - [css-grid] Update <fixed-size> parsing to the latest spec

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Mats Palmgren (inactive)]

The syntax for <fixed-size> recently changed to:
<fixed-size> = 
  <fixed-breadth> | 
  minmax( <fixed-breadth> , <track-breadth> ) |
  minmax( <track-breadth> , <fixed-breadth> )
https://drafts.csswg.org/css-grid/#typedef-fixed-size

I think our layout code already handles this correctly though - we use
the max-sizing function if it's definite, otherwise the min-sizing.

I should update the code comment here though since the spec text changed:
http://hg.mozilla.org/mozilla-central/annotate/5e0140b6d118/layout/generic/nsGridContainerFrame.cpp#l428

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

Comment 2

[Mats Palmgren (inactive)]

Attachment: tests

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e765eee3da98

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8724826 [details] [diff] [review]
fix

Review of attachment 8724826 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for being on top of this spec-change!

r=me, just one nit:

::: layout/style/nsCSSParser.cpp
@@ +8603,5 @@
>  CSSParseResult
>  CSSParserImpl::ParseGridTrackSize(nsCSSValue& aValue,
>                                    GridTrackSizeFlags aFlags)
>  {
> +  const bool requireFixedSize = !!(aFlags & GridTrackSizeFlags::eFixedTrackSize);

This line is a little too long -- either wrap after the "=", or do something like s/require/need/ in the variable-name to shorten.

Comment 4

[Daniel Holbert [:dholbert]]

I skimmed the tests, too, & they seem sane - feel free to mark those as rs=dholbert if you like

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd98615e4b4b
https://hg.mozilla.org/integration/mozilla-inbound/rev/9060d17ed510

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd98615e4b4b
https://hg.mozilla.org/mozilla-central/rev/9060d17ed510