Closed
Bug 1252465
Opened 8 years ago
Closed 8 years ago
Link taps don't work at the bottom of reader view page
Categories
(Firefox for Android Graveyard :: Reader View, defect)
Firefox for Android Graveyard
Reader View
Tracking
(firefox47 verified, firefox48 verified, fennec47+)
VERIFIED
FIXED
Firefox 48
People
(Reporter: Margaret, Assigned: capella)
References
Details
Attachments
(1 file)
1017 bytes,
patch
|
Margaret
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This is likely a regression from bug 1226238. I suspect that there's still a transparent toolbar element taking up the full width of the screen, so it's intercepting taps intended for links below.
Assignee | ||
Comment 2•8 years ago
|
||
Good tip-off, confirmed w/WebIDE ... fix seems simple.
Assignee: margaret.leibovic → markcapella
Status: NEW → ASSIGNED
Attachment #8733210 -
Flags: review?(margaret.leibovic)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8733210 [details] [diff] [review] bug1252465.diff Review of attachment 8733210 [details] [diff] [review]: ----------------------------------------------------------------- Works for me!
Attachment #8733210 -
Flags: review?(margaret.leibovic) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/69b843ebaa27
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8733210 [details] [diff] [review] bug1252465.diff Approval Request Comment: As suggested in comment # 6, please upload to v47 / currently Beta. [Feature/regressing bug #]: This is likely a regression from bug 1226238. [User impact if declined]: Sub-optimal UI interaction in an otherwise most-excellent new implementation. [Describe test coverage new/current, TreeHerder]: All testing done via UI, baked in Aurora, Central, and local queues prior to that. [Risks and why]: Seems to be none, small change, easily backed out. [String/UUID change made/needed]: None
Flags: needinfo?(markcapella)
Attachment #8733210 -
Flags: approval-mozilla-beta?
Comment on attachment 8733210 [details] [diff] [review] bug1252465.diff Regression in reader view, baked in Nightly for a while, Beta47+
Attachment #8733210 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox47:
--- → affected
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/472ba65eeb68
Comment 10•8 years ago
|
||
Verified as fixed on Firefox 47 Beta 4 and latest Aurora on Samsung Galaxy S6 Edge (Android 5.1.1)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•