Closed
Bug 1252557
Opened 9 years ago
Closed 9 years ago
Fix remaining lint issues so we can add lint to automation
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(3 files)
There appear to be 4 remaining.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37429/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37429/
Attachment #8725351 -
Flags: review?(nalexander)
|
|
Assignee | |
Comment 2•9 years ago
|
||
afaict, we don't currently support app indexing (bug 1252569) so this should be
okay to reduce the warning level. We can ignore it if we decide we don't want
to support this feature.
Review commit: https://reviewboard.mozilla.org/r/37431/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37431/
Attachment #8725352 -
Flags: review?(nalexander)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37433/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37433/
Attachment #8725353 -
Flags: review?(nalexander)
|
|
Assignee | |
Updated•9 years ago
|
Blocks: android-lint-automation
Comment on attachment 8725351 [details]
MozReview Request: Bug 1252557 - Add ignore for HardcodedDebugMode. r=nalexander
https://reviewboard.mozilla.org/r/37429/#review33987
Sure.
Attachment #8725351 -
Flags: review?(nalexander) → review+
Comment on attachment 8725352 [details]
MozReview Request: Bug 1252557 - Add warning for GoogleAppIndexingDeepLinkError. r=nalexander
https://reviewboard.mozilla.org/r/37431/#review33989
Attachment #8725352 -
Flags: review?(nalexander) → review+
Comment on attachment 8725353 [details]
MozReview Request: Bug 1252557 - Suppress ParcelCreator in AndroidFxAccount. r=nalexander
https://reviewboard.mozilla.org/r/37433/#review33991
Attachment #8725353 -
Flags: review?(nalexander) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fb53f603ce51a553025a9f4adbaf81be416f861a
Bug 1252557 - Add ignore for HardcodedDebugMode. r=nalexander
https://hg.mozilla.org/integration/fx-team/rev/6bb4a1fc9967cdc5ed2ed5512a36756c33c35c05
Bug 1252557 - Add warning for GoogleAppIndexingDeepLinkError. r=nalexander
https://hg.mozilla.org/integration/fx-team/rev/a01fcd62cc61293aac1e32a543937b39dc987080
Bug 1252557 - Suppress ParcelCreator in AndroidFxAccount. r=nalexander
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fb53f603ce51
https://hg.mozilla.org/mozilla-central/rev/6bb4a1fc9967
https://hg.mozilla.org/mozilla-central/rev/a01fcd62cc61
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•