Fix remaining lint issues so we can add lint to automation

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

(Blocks 1 bug)

unspecified
Firefox 47
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(3 attachments)

There appear to be 4 remaining.
afaict, we don't currently support app indexing (bug 1252569) so this should be
okay to reduce the warning level. We can ignore it if we decide we don't want
to support this feature.

Review commit: https://reviewboard.mozilla.org/r/37431/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37431/
Attachment #8725352 - Flags: review?(nalexander)
Comment on attachment 8725351 [details]
MozReview Request: Bug 1252557 - Add ignore for HardcodedDebugMode. r=nalexander

https://reviewboard.mozilla.org/r/37429/#review33987

Sure.
Attachment #8725351 - Flags: review?(nalexander) → review+
Comment on attachment 8725352 [details]
MozReview Request: Bug 1252557 - Add warning for GoogleAppIndexingDeepLinkError. r=nalexander

https://reviewboard.mozilla.org/r/37431/#review33989
Attachment #8725352 - Flags: review?(nalexander) → review+
Comment on attachment 8725353 [details]
MozReview Request: Bug 1252557 - Suppress ParcelCreator in AndroidFxAccount. r=nalexander

https://reviewboard.mozilla.org/r/37433/#review33991
Attachment #8725353 - Flags: review?(nalexander) → review+

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fb53f603ce51
https://hg.mozilla.org/mozilla-central/rev/6bb4a1fc9967
https://hg.mozilla.org/mozilla-central/rev/a01fcd62cc61
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.