1252570 - Remove mozPay

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

The Marketplace is removing payments support [1], so we can get rid of all mozPay related code.

[1] https://wiki.mozilla.org/Marketplace#Upcoming_Changes_to_Marketplace

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c7e8d33f084

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Intent to unship email https://groups.google.com/forum/#!topic/mozilla.dev.platform/FvzDoaPGQ3g

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8735107 [details] [diff] [review]
v1

Could you take a look at this patch, please?

Fabrice, for the B2G part.

Ehsan, DOM and desktop parts.

Mark, Android parts.

Thanks!

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 8735107 [details] [diff] [review]
v1

Review of attachment 8735107 [details] [diff] [review]:
-----------------------------------------------------------------

Just wait for TV 2.6 to branch before landing.

Comment 7

[Kohei Yoshino [:kohei]]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/non-standard-web-payments-api-has-been-removed/

Comment 8

[[:fabrice] Fabrice Desré]

(In reply to Kohei Yoshino [:kohei] from comment #7)
> Posted the site compatibility doc:
> https://www.fxsitecompat.com/en-CA/docs/2016/non-standard-web-payments-api-
> has-been-removed/

This is not yet the case, since this patch has not landed.

Comment 9

[Kohei Yoshino [:kohei]]

/me clicked the button too quickly ;)

Comment 10

[:Margaret Leibovic]

Comment on attachment 8735107 [details] [diff] [review]
v1

Review of attachment 8735107 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review from mfinkle. I was about to file a bug about removing these mobile tests, since it looks like we missed them as part of bug 1251373.

::: mobile/android/tests/browser/chrome/test_jni.html
@@ -41,5 @@
> -          { name: "getMCC", sig: "()I" },
> -        ],
> -      });
> -      is(typeof jGeckoNetworkManager.getMNC(), "number", "typeof getMNC is number");
> -      is(typeof jGeckoNetworkManager.getMCC(), "number", "typeof getMCC is number");

GeckoNetworkManager still exists. If it's unused, we should have another bug/patch to remove it. I don't think removing this test logic is in the scope of this bug if we still support these methods.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #10)

> GeckoNetworkManager still exists. If it's unused, we should have another
> bug/patch to remove it. I don't think removing this test logic is in the
> scope of this bug if we still support these methods.

GeckoNetworkManager is still used

Comment 12

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #11)
> (In reply to :Margaret Leibovic from comment #10)
> 
> > GeckoNetworkManager still exists. If it's unused, we should have another
> > bug/patch to remove it. I don't think removing this test logic is in the
> > scope of this bug if we still support these methods.
> 
> GeckoNetworkManager is still used

In that case, let's not remove this test coverage :)

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

Sure. Thanks for the review!

Comment 14

[:gerard-majax]

Attachment: Remove mozPay.

Updated patch on top of current central.

Comment 15

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #14)
> Created attachment 8782888 [details] [diff] [review]
> Remove mozPay.
> 
> Updated patch on top of current central.

Conflicted:
	b2g/chrome/content/shell.js.rej
	b2g/components/moz.build.rej
	b2g/confvars.sh.rej
	b2g/graphene/confvars.sh.rej
	b2g/installer/package-manifest.in.rej
	browser/confvars.sh.rej
	browser/installer/package-manifest.in.rej
	docshell/base/nsDocShell.h.rej
	dom/base/Navigator.cpp.rej
	dom/base/Navigator.h.rej
	dom/moz.build.rej
	dom/webidl/moz.build.rej
	mobile/android/tests/browser/robocop/robocop.ini.rej
	old-configure.in.rej

Comment 16

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=58789a1579e5

Comment 17

[:gerard-majax]

Attachment: Remove mozPay.

Eradicate dom/payment/

Comment 18

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8117ff1b2a92

Comment 19

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=146433558460

Comment 20

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e03243866f6

Comment 21

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=07a5923b8691

Comment 22

[:gerard-majax]

Attachment: Remove mozPay.

Keeping GeckoNetworkManager assertions as requested in comment 10.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2454585e72
Remove mozPay. r=ehsan,mfinkle,fabrice

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a2454585e72