1252717 - Switch all passing lint warnings to errors

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

After we land in automation – bug 1238788.

Afterwards, we should add them incrementally as we fix the issues.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

`lint --show` will be useful here.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: list of all current lint warnings

lint --show | grep -i "^[a-z]\+$" | sort > warnings

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: list of our current warnings

On the list results html page:

re = /.*:/
issueElem = document.getElementsByClassName('issueColumn');
for (let e of issueElem) {
  linkText = e.children[1].innerText
  matchingText = re.exec(linkText)[0]
  matchingTextWithoutColon = matchingText.slice(0, -1)
  console.log(matchingTextWithoutColon);
}

// Copy-pasta to text file and run `sort` on it

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: python script to extract the checks we pass

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: list of checks we pass

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1252717 - Set all passing android lint warnings as errors. r=me

I made all of the checks that:
  * We pass
  * Weren't already disabled

Into errors. There may be some checks we don't actually want, in which case we
can remove them from this list when we fail them.

Review commit: https://reviewboard.mozilla.org/r/38351/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38351/

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This is a list of xml that passed linting locally – I don't think it needs a review.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/be8a2e0cc1cf9e7c0f8f1645c9e37167f99b9d3a
Bug 1252717 - Set all passing android lint warnings as errors. r=me

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be8a2e0cc1cf