WebrtcMediaCodecVP8VideoEncoder::InitEncode is invalid function define

RESOLVED FIXED in Firefox 47

Status

()

Core
WebRTC: Audio/Video
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla47
Unspecified
Android
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

3rd parameter type of VideoEncoder ::InitEncode (/media/webrtc/trunk/webrtc/video_encoder.h) is size_t, but WebrtcMediaCodecVP8VideoEncoder::InitEncode is uint32_t...
OS: Unspecified → Android

Updated

2 years ago
Component: WebRTC: Signaling → WebRTC: Audio/Video
Created attachment 8725530 [details]
MozReview Request: Bug 1252737 - use size_t instead of uint32_t for InitEncode(). r?jesup

Although 3rd parameter VideoEncodeer::InitEncode() is defiend as size_t, WebrtcIMXH264VideoCodec and WebrtcMediaCodecVP8VideoCodec uses uint32_t.  This will cause build error for 64bit platform.

Review commit: https://reviewboard.mozilla.org/r/37555/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37555/
Attachment #8725530 - Flags: review?(rjesup)
Comment on attachment 8725530 [details]
MozReview Request: Bug 1252737 - use size_t instead of uint32_t for InitEncode(). r?jesup

https://reviewboard.mozilla.org/r/37555/#review34135

::: media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.h:38
(Diff revision 1)
> -                              uint32_t maxPayloadSize) override;
> +                             size_t maxPayloadSize) override;

Good, but I'm surprised it didn't kick out due to "override" - what was it overriding, and why didn't the compiler decide that size_t and uint32_t didn't match (even on 32-bit)?  However, perhaps not important; really a compiler issue.
Attachment #8725530 - Flags: review?(rjesup) → review+

Comment 3

2 years ago
https://reviewboard.mozilla.org/r/37555/#review34135

> Good, but I'm surprised it didn't kick out due to "override" - what was it overriding, and why didn't the compiler decide that size_t and uint32_t didn't match (even on 32-bit)?  However, perhaps not important; really a compiler issue.

The compiler only cares if the types actually differ on the platform in question. Same goes for warnings about printf format strings.

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9a420d13d5c

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b9a420d13d5c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Blocks: 1322020
You need to log in before you can comment on or make changes to this bug.