1252737 - WebrtcMediaCodecVP8VideoEncoder::InitEncode is invalid function define

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Makoto Kato [:m_kato]]

3rd parameter type of VideoEncoder ::InitEncode　(/media/webrtc/trunk/webrtc/video_encoder.h) is size_t, but WebrtcMediaCodecVP8VideoEncoder::InitEncode is uint32_t...

Comment 1

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1252737 - use size_t instead of uint32_t for InitEncode(). r?jesup

Although 3rd parameter VideoEncodeer::InitEncode() is defiend as size_t, WebrtcIMXH264VideoCodec and WebrtcMediaCodecVP8VideoCodec uses uint32_t.  This will cause build error for 64bit platform.

Review commit: https://reviewboard.mozilla.org/r/37555/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37555/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8725530 [details]
MozReview Request: Bug 1252737 - use size_t instead of uint32_t for InitEncode(). r?jesup

https://reviewboard.mozilla.org/r/37555/#review34135

::: media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.h:38
(Diff revision 1)
> -                              uint32_t maxPayloadSize) override;
> +                             size_t maxPayloadSize) override;

Good, but I'm surprised it didn't kick out due to "override" - what was it overriding, and why didn't the compiler decide that size_t and uint32_t didn't match (even on 32-bit)?  However, perhaps not important; really a compiler issue.

Comment 3

[Byron Campen [:bwc]]

https://reviewboard.mozilla.org/r/37555/#review34135

> Good, but I'm surprised it didn't kick out due to "override" - what was it overriding, and why didn't the compiler decide that size_t and uint32_t didn't match (even on 32-bit)?  However, perhaps not important; really a compiler issue.

The compiler only cares if the types actually differ on the platform in question. Same goes for warnings about printf format strings.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9a420d13d5c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b9a420d13d5c