1322020 - There's no "toggle split console" button in Browser Toolbox

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[el8]

User Agent: Mozilla/5.0 (Windows NT 6.0; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161129173726

Steps to reproduce:

1. Open Browser Toolbox (Ctrl-Alt-Shift-I)
2. In Inspector rightclick any item and chose "Show DOM Properties"
3. The Console will appear in the lower part of the window.

There's no way to hide it - no "toggle split console" button on the toolbar and no checkbox for enabling it among the available toolbox buttons in the toolbox options.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for the report!  Seems like there was a button once upon a time, at least looking at bug 1011174.

:bgrins, do you know if this was later removed?

Comment 2

[Brian Grinstead [:bgrins]]

There definitely used to be a button.  I don't think it was removed intentionally.

Comment 3

[Justin [:JW_SoftvisionQA]]

I attempted to run a Mozregression on this bug but I can not find a time when there was a button to hide/toggle the console. It looks like "Show Dom Properties" was implemented in Nightly on 2014-09-09 and it has the same functionality as today's current Nightly.

Comment 4

[Justin [:JW_SoftvisionQA]]

I stand corrected. Here is the regression range for this issue:

25:09.23 INFO: Last good revision: 3511cf3b224219d96cbb851e3ef903c92627b836
25:09.24 INFO: First bad revision: b9a420d13d5cc7e6c23896dd468c9f087fa16c55
25:09.24 INFO: Pushlog:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3511cf3b224219d96cbb851e3ef903c92627b836&tochange=b9a420d13d5cc7e6c23896dd468c9f087fa16c55

25:10.81 INFO: Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1252737

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Justin [:JW_SoftvisionQA] from comment #4)
> I stand corrected. Here is the regression range for this issue:
> 
> 25:09.23 INFO: Last good revision: 3511cf3b224219d96cbb851e3ef903c92627b836
> 25:09.24 INFO: First bad revision: b9a420d13d5cc7e6c23896dd468c9f087fa16c55
> 25:09.24 INFO: Pushlog:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=3511cf3b224219d96cbb851e3ef903c92627b836&tochange=b9a4
> 20d13d5cc7e6c23896dd468c9f087fa16c55
> 
> 25:10.81 INFO: Looks like the following bug has the changes which introduced
> the regression:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1252737

Really?  This change is for Android build only.

Comment 6

[Andrew Overholt [:overholt]]

Maybe mozregression got confused somehow? Can you try again, Justin?

Comment 7

[Justin [:JW_SoftvisionQA]]

Attachment: browser toolbox console onoff switch.mp4

Before I run another Mozregression lets verify that I am understanding this issue correctly. Attached is a video of the steps I am using to reproduce.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Justin [:JW_SoftvisionQA] from comment #7)
> Created attachment 8830496 [details]
> browser toolbox console onoff switch.mp4
> 
> Before I run another Mozregression lets verify that I am understanding this
> issue correctly. Attached is a video of the steps I am using to reproduce.

While "Show DOM properties" is mentioned by the reporter, I don't think it's related to the core issue about the "split console" button.

So, here's a reduced STR:

1. Open Browser Toolbox
2. Try to toggle the split console on / off
  * It's possible the button is available but disabled, so you may need to check the DevTools options / gear icon, look for "Available Toolbox Buttons", and see if there is an entry for "Toggle split console"

ER:

A split console button exists, or at least can enabled from toolbox options

AR:

There is no split console button, and no way to enable it

Comment 9

[Justin [:JW_SoftvisionQA]]

Below is the regression I came up with from the steps in comment 8. I hope this is helpful.

10:26.64 INFO: Last good revision: cef590a6f946 (2014-11-27)
10:26.64 INFO: First bad revision: 17de0f463944 (2014-11-28)
10:26.64 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cef590a6f946&tocha
nge=17de0f463944

Comment 10

[Justin [:JW_SoftvisionQA]]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cef590a6f946&tochange=17de0f463944

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In recent builds of Nightly 54, this seems fixed to me.

I suspect it was fixed by bug 1320149 which reworked these buttons.

:JW_SoftvisionQA and / or :el8, can you check in Nightly 54 as well to see if it's fixed for you?

Comment 12

[Justin [:JW_SoftvisionQA]]

Yes it does look like this has been fixed on my machine.

 	Mozilla/5.0 (Windows NT 6.3; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Great!  Since it's the Browser Toolbox, I think we can let this ride the trains.

Comment 14

[suba4598]

bugday[20170308]

Comment 15

[Dustin Driver]

Docs update here: https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Step_through_code

Comment 16

[el8]

> el8, can you check in Nightly 54 as well to see if it's fixed for you?
It's fixed, thanks.