Closed Bug 1252803 Opened 5 years ago Closed 1 year ago

Enable ESLint on the rest of devtools

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: pbro, Assigned: marco, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(2 files)

Bug 1252803 - Enable ESLint on the rest of devtools (automatic changes).
47 bytes, text/x-phabricator-request
Details | Review
Bug 1252803 - Enable ESLint on the rest of devtools (manual changes).
47 bytes, text/x-phabricator-request
Details | Review 
No description provided.
I have started to clean a lot of the code in devtools/server. I will attach some patches for review here.
Priority: -- → P3
Whiteboard: [btpp-backlog]
Blocks: devtools-eslint
Product: Firefox → DevTools

After bug 1589334 is ready, the remaining directories where we are still disabling are:

devtools/client/inspector/markup/test/doc_markup_events_*.html
devtools/client/performance/components/test/test_jit_optimizations_01.html
devtools/server/tests/browser/storage-*.html
!devtools/server/tests/browser/storage-unsecured-iframe.html
devtools/server/tests/browser/stylesheets-nested-iframes.html
devtools/client/webreplay/mochitest/examples/*.html

They seem small enough that we can cover in one bug, and Marco has offered to take this on. Hence assigning Marco to the bug and I'll help out as necessary.

Assignee: nobody → marco
Mentor: standard8
Depends on: 1589334
Summary: Fix all ESLint errors in devtools/server/ and un-ignore this directory → Enable ESLint on the rest of devtools

For react files and similar, the anonymous function was named because react/display-name was being triggered if the render function was unnamed.

Hi Marco, are you still able to work on this?

Flags: needinfo?(marco)

I've not heard back from Marco, so I'm going to fix the nits and push this to final landing.

Assignee: marco → standard8
Flags: needinfo?(marco)
Attachment #9116044 - Attachment description: Bug 1252803 - Enable ESLint on the rest of devtools (automatic changes). r=Standard8 → Bug 1252803 - Enable ESLint on the rest of devtools (automatic changes).
Attachment #9116045 - Attachment description: Bug 1252803 - Enable ESLint on the rest of devtools (manual changes). r=Standard8 → Bug 1252803 - Enable ESLint on the rest of devtools (manual changes).
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d437e6ae3de2
Enable ESLint on the rest of devtools (automatic changes). r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/b470bfe4bd47
Enable ESLint on the rest of devtools (manual changes). r=jdescottes

https://hg.mozilla.org/mozilla-central/rev/d437e6ae3de2
https://hg.mozilla.org/mozilla-central/rev/b470bfe4bd47

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74

Assigning back to Marco as they did most of the work here. Thank you Marco.

Assignee: standard8 → marco
You need to log in before you can comment on or make changes to this bug.