Closed
Bug 1252803
Opened 9 years ago
Closed 5 years ago
Enable ESLint on the rest of devtools
Categories
(DevTools :: General, defect, P3)
DevTools
General
Tracking
(firefox74 fixed)
RESOLVED
FIXED
Firefox 74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: pbro, Assigned: marco, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(2 files)
No description provided.
|
Reporter | |
Comment 1•9 years ago
|
||
I have started to clean a lot of the code in devtools/server. I will attach some patches for review here.
Priority: -- → P3
Whiteboard: [btpp-backlog]
|
||
Updated•9 years ago
|
Blocks: devtools-eslint
|
||
Updated•7 years ago
|
Blocks: dt-polish-debt
|
|
||
Updated•7 years ago
|
No longer blocks: dt-polish-debt
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
||
Comment 2•5 years ago
|
||
After bug 1589334 is ready, the remaining directories where we are still disabling are:
devtools/client/inspector/markup/test/doc_markup_events_*.html
devtools/client/performance/components/test/test_jit_optimizations_01.html
devtools/server/tests/browser/storage-*.html
!devtools/server/tests/browser/storage-unsecured-iframe.html
devtools/server/tests/browser/stylesheets-nested-iframes.html
devtools/client/webreplay/mochitest/examples/*.html
They seem small enough that we can cover in one bug, and Marco has offered to take this on. Hence assigning Marco to the bug and I'll help out as necessary.
Assignee: nobody → marco
Mentor: standard8
Depends on: 1589334
Summary: Fix all ESLint errors in devtools/server/ and un-ignore this directory → Enable ESLint on the rest of devtools
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D57223
|
|
Assignee | |
Comment 5•5 years ago
|
||
For react files and similar, the anonymous function was named because react/display-name was being triggered if the render function was unnamed.
|
|
||
Comment 7•5 years ago
|
||
I've not heard back from Marco, so I'm going to fix the nits and push this to final landing.
Assignee: marco → standard8
|
|
||
Updated•5 years ago
|
Flags: needinfo?(marco)
|
||
Updated•5 years ago
|
Attachment #9116044 -
Attachment description: Bug 1252803 - Enable ESLint on the rest of devtools (automatic changes). r=Standard8 → Bug 1252803 - Enable ESLint on the rest of devtools (automatic changes).
|
|
||
Updated•5 years ago
|
Attachment #9116045 -
Attachment description: Bug 1252803 - Enable ESLint on the rest of devtools (manual changes). r=Standard8 → Bug 1252803 - Enable ESLint on the rest of devtools (manual changes).
|
|
||
Comment 8•5 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d437e6ae3de2
Enable ESLint on the rest of devtools (automatic changes). r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/b470bfe4bd47
Enable ESLint on the rest of devtools (manual changes). r=jdescottes
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d437e6ae3de2
https://hg.mozilla.org/mozilla-central/rev/b470bfe4bd47
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
|
|
||
Comment 11•5 years ago
|
||
Assigning back to Marco as they did most of the work here. Thank you Marco.
Assignee: standard8 → marco
You need to log in
before you can comment on or make changes to this bug.
Description
•