Closed
Bug 1252862
Opened 8 years ago
Closed 8 years ago
Remove calls to delete_token() in several places where it is unnecessary
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dkl, Assigned: dkl)
Details
Attachments
(1 file)
|
1.92 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
Since we use issue_hash_token and check_hash_token, the tokens are not actually stored in the DB and therefore delete_token is not needed. The calls are harmless but should be removed nonetheless. Files affected: http://git.mozilla.org/?p=webtools/bmo/bugzilla.git;a=blob;f=extensions/BMO/Extension.pm;h=35ce9b8d69b155909bcb804b35928299700cc458;hb=HEAD#l261 [github] http://git.mozilla.org/?p=webtools/bmo/bugzilla.git;a=blob;f=extensions/Push/lib/Admin.pm;h=e11415ea69c1c73ec8b2c716b73a4ed41608c980;hb=HEAD#l34 [github] http://git.mozilla.org/?p=webtools/bmo/bugzilla.git;a=blob;f=extensions/EditTable/Extension.pm;h=675b3fe90234567fb35f6256372d3ae0bd6e97f8;hb=HEAD#l91 [github]
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8725674 -
Flags: review?(dylan)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8725674 [details] [diff] [review] 1252862_1.patch Review of attachment 8725674 [details] [diff] [review]: ----------------------------------------------------------------- r=dylan
Attachment #8725674 -
Flags: review?(dylan) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 00f9ff6..f559a15 master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•