Port ValueSelector refactor from System to TV System

RESOLVED FIXED

Status

Firefox OS
Gaia::L10n
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In bug 1235975 we migrated System app to use modern L10n API and work with RTL languages.

We need to port those changes to TV System so that we can migrate TV System to l20n.
(Assignee)

Updated

2 years ago
Blocks: 1247710
(Assignee)

Updated

2 years ago
Assignee: nobody → gandalf
Created attachment 8725765 [details] [review]
[gaia] zbraniecki:1252936-migrate-smart-system-value-selector-to-modern-l10n > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8725765 [details] [review]
[gaia] zbraniecki:1252936-migrate-smart-system-value-selector-to-modern-l10n > mozilla-b2g:master

Ok, since this is the last functional change needed to finish transitioning TV to L20n, and :albertopq is not sure if we'll be able to just switch TV to System's ValueSelector, I ported manually the changes.

This patch removes the mozL10n.get calls, and makes the value selector work with RTL languages and non-latin digit-systems.
Attachment #8725765 - Flags: review?(rexboy)
Comment on attachment 8725765 [details] [review]
[gaia] zbraniecki:1252936-migrate-smart-system-value-selector-to-modern-l10n > mozilla-b2g:master

As far as I know we didn't make significant changes to value selector and data pickers, so it should be OK to port them here directly.
Attachment #8725765 - Flags: review?(rexboy) → review+
(Assignee)

Comment 5

2 years ago
ok, cool! :) Thanks!
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.