Closed Bug 1247710 Opened 8 years ago Closed 8 years ago

Migrate Smart-System to L20n.js

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

      No description provided.
Depends on: 1247774
Depends on: 1246588
I'm going to split this work into four parts:

1) Migrate FxA refactor
2) Consolidate ValueSelector
3) Final bunch of mozL10n.get removals
4) This bug which will basically move l10n.js to l20n.js and update API calls
Depends on: 1247780
Alberto, I'm done with porting TV System to be ready for L20n. The remaining piece is bug 1246588. Once this is done, I'll switch TV System and then both systems will use L20n.

Am I correct to assume that bug 1246588 is on you?
Flags: needinfo?(apastor)
It seems that the merge is not finally happening (let's talk offline about it) so I'm not sure what the next steps are.
Flags: needinfo?(apastor)
Ok, in the meantime, I filed bug 1252936 so that I can port just the L10n/I18n portion of the changes and unblock moving smart-system to l20n.
Depends on: 1252936
No longer depends on: 1246588
Assignee: nobody → gandalf
Comment on attachment 8727452 [details] [review]
[gaia] zbraniecki:1247710-migrate-smart-system-to-l20n > mozilla-b2g:master

And the very last patch for the TV refactor! :)

This one just moves Smart System from l10n.js to l20n.js. Most of the transition is automatic:

1) navigator.mozL10n.* -> document.l10n.*
2) navigator.mozL10n.once -> document.l10n.ready.then

In a few places I removed the mozL10n.once wrapper because it's not needed anymore (whole L10n is asynchronous and doesn't have to wait for anything).

In one place - net_error.html - I left l10n.js because it requires all l10n resources to be loaded locally and l20n.js doesn't support that yet.
That's also what we did for ./apps/system and I filed bug 1247096 to tackle that separately.
Attachment #8727452 - Flags: review?(rexboy)
Comment on attachment 8727452 [details] [review]
[gaia] zbraniecki:1247710-migrate-smart-system-to-l20n > mozilla-b2g:master

Looks good to me!
Attachment #8727452 - Flags: review?(rexboy) → review+
Cool! Thanks!

That concludes the whole moving TV to L20n story! :)

Commit: https://github.com/mozilla-b2g/gaia/commit/6e176e0584fdb0dcc59b041ecc2a38aaf2477996
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 1257741
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: