Closed Bug 1253330 Opened 4 years ago Closed 4 years ago

Fix heap-tree-item-field heap-tree-item-name inline style (margin-left) in RTL

Categories

(DevTools :: Memory, defect, P3)

defect

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: fitzgen, Assigned: steveck)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

https://dxr.mozilla.org/mozilla-central/search?q=marginLeft+path%3Adevtools%2Fclient%2Fmemory&redirect=false&case=false
marginLeft should be replaced with marginInlineStart
Whiteboard: [good first bug][lang=js]
Assignee: nobody → schung
Status: NEW → ASSIGNED
Comment on attachment 8777228 [details]
Bug 1253330 - Fix heap-tree-item-field heap-tree-item-name inline style (margin-left) in RTL.

https://reviewboard.mozilla.org/r/68818/#review65976

Fixes the issue for me. the arrow is still backwards, but that's another bug.
Attachment #8777228 - Flags: review?(ntim.bugs) → review+
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/83a4d6ae5673
Fix heap-tree-item-field heap-tree-item-name inline style (margin-left) in RTL. r=ntim
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/83a4d6ae5673
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.