1253330 - Fix heap-tree-item-field heap-tree-item-name inline style (margin-left) in RTL

Status: RESOLVED FIXED

(DevTools :: Memory, defect, P3)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1224192#c4

See attachment 8726122 [details].

Comment 1

[Tim Nguyen :ntim]

https://dxr.mozilla.org/mozilla-central/search?q=marginLeft+path%3Adevtools%2Fclient%2Fmemory&redirect=false&case=false
marginLeft should be replaced with marginInlineStart

Comment 2

[Steve Chung [:steveck]]

Attachment: Bug 1253330 - Fix heap-tree-item-field heap-tree-item-name inline style (margin-left) in RTL.

Review commit: https://reviewboard.mozilla.org/r/68818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68818/

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8777228 [details]
Bug 1253330 - Fix heap-tree-item-field heap-tree-item-name inline style (margin-left) in RTL.

https://reviewboard.mozilla.org/r/68818/#review65976

Fixes the issue for me. the arrow is still backwards, but that's another bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/83a4d6ae5673
Fix heap-tree-item-field heap-tree-item-name inline style (margin-left) in RTL. r=ntim

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/83a4d6ae5673