1224192 - [RTL][devtools] Memory tool direction in RTL locales

Status: RESOLVED FIXED

(DevTools :: Memory, defect, P3)

Description

[magicp]

Attachment: rtl-devtools-memory-direction.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20151111030207

Steps to reproduce:

1. Run Nightly in RTL locales (e.g. Arabic)
2. Open any sites (e.g. about:home)
3. Open devtools > Memory


Actual results:

Memory tool does not have RTL direction in RTL locales.


Expected results:

Memory tool should have RTL direction.

Comment 1

[Oussama Ben Guirat [:obg]]

Attachment: myfirstpatch

Tim, can you review this please ?

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8725238 [details] [diff] [review]
myfirstpatch

Review of attachment 8725238 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 3

[Tim Nguyen :ntim]

This landed with the wrong bug number in bug 1206341.
Here are the changesets:
https://hg.mozilla.org/integration/fx-team/rev/d6788a70c97b
https://hg.mozilla.org/mozilla-central/rev/d6788a70c97b

Comment 4

[magicp]

Attachment: devtools-memory-rtl.png

The following items should be fixed...
- direction of heap-tree-number
- text-align of heap-tree-number and heap-tree-percent
- direction of twisty and children-pointer
- text position in graph
- heap-tree-item-field heap-tree-item-name inline style (margin-left)

Comment 5

[Tim Nguyen :ntim]

Please file new bugs for these

Comment 6

[magicp]

(In reply to Tim Nguyen [:ntim] (busy, email me instead) from comment #5)
> Please file new bugs for these

You should!

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I have filed the following bugs for these RTL issues:

* Bug 1253323
* Bug 1253324
* Bug 1253327
* Bug 1253328
* Bug 1253330

Generally, we tend to prefer new bugs. I totally understand that both of you are volunteers and are not paid to work on the project full time, so if there is ever any busy work kind of things (like filing individual new bugs) please just ping me and I can happily do it. Finally, both of you have done a lot to increase the memory tool's polish level, and we're all on the same team. Please give the benefit of the doubt to each other :)

Thank you both for all your contributions!

Comment 8

[magicp]

(In reply to Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] from comment #7)
> I have filed the following bugs for these RTL issues:

Thanks Nick.

> Generally, we tend to prefer new bugs. I totally understand that both of you
> are volunteers and are not paid to work on the project full time, so if
> there is ever any busy work kind of things (like filing individual new bugs)
> please just ping me and I can happily do it. Finally, both of you have done
> a lot to increase the memory tool's polish level, and we're all on the same
> team. Please give the benefit of the doubt to each other :)
> 
> Thank you both for all your contributions!

Almost RTL bugs can avoid issue in the first place with to confirm the UI(screenshot) in review process. But now, new bugs will be partially filed and priority will be low and awaiting long time response. As you may know, the searchSubmit arrow still is wrong direction in "about:home" on RTL locales. So I thought that "reopen" is good approach for these.