Closed Bug 1253339 Opened 5 years ago Closed 5 years ago

Remove about:feedback code

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

After we land bug 1239513 and verify the new input page is working as expected, we should go ahead and remove the about:feedback code from the tree.
Comment on attachment 8726406 [details]
MozReview Request: Bug 1253339 - Remove about:feedback code. r=sebastian

https://reviewboard.mozilla.org/r/37967/#review34673

Lots of red. I approve.
Attachment #8726406 - Flags: review?(s.kaspari) → review+
Status: NEW → ASSIGNED
OS: Unspecified → Android
Hardware: Unspecified → All
https://hg.mozilla.org/mozilla-central/rev/578af45f29a8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
If I uplift a patch that removes an entire .dtd file, does that cause problems for our l10n tools?
Flags: needinfo?(francesco.lodolo)
(In reply to :Margaret Leibovic from comment #5)
> If I uplift a patch that removes an entire .dtd file, does that cause
> problems for our l10n tools?

It definitely creates noise since the file will be reported. If we can have a patch that doesn't remove the file it would be great.
Flags: needinfo?(francesco.lodolo)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.