1253339 - Remove about:feedback code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

After we land bug 1239513 and verify the new input page is working as expected, we should go ahead and remove the about:feedback code from the tree.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1253339 - Remove about:feedback code. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/37967/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37967/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8726406 [details]
MozReview Request: Bug 1253339 - Remove about:feedback code. r=sebastian

https://reviewboard.mozilla.org/r/37967/#review34673

Lots of red. I approve.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/578af45f29a839a6e023b9148bdf4cc0d72c2864
Bug 1253339 - Remove about:feedback code. r=sebastian

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/578af45f29a8

Comment 5

[:Margaret Leibovic]

If I uplift a patch that removes an entire .dtd file, does that cause problems for our l10n tools?

Comment 6

[Francesco Lodolo [:flod]]

(In reply to :Margaret Leibovic from comment #5)
> If I uplift a patch that removes an entire .dtd file, does that cause
> problems for our l10n tools?

It definitely creates noise since the file will be reported. If we can have a patch that doesn't remove the file it would be great.