125341 - AIX bustage due the |char*|-->|const char*|-changes in bug

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Roland Mainz]

AIX tinderbox "torino" is RED
(http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/1013543460.23067.gz)
due checkin of bug 120916 ("PostScript/Xprint module revamp"). It looks that the
AIX compiler is somehow very picky about the |char*|-->|const char*|-changes in
those patches.

Currently "torino" is down do other issues (machine broken ?!), I'll have to
wait until the machine is "up" again until I can checkin a fix.

Question:
- Who is right ? The AIX-compiler or {gcc, Sun Workshop, Mac compilers, etc.
...} ? Am I allowed to |delete my_const_char_ptr;| ?

Comment 1

[Jim Dunn]

fyi: torino was down due to a system issue. 
It is now back up and running.

Comment 2

[Jim Dunn]

Attachment: quick patch to fix aix bustage

NOTE this was fixed back in revision 1.7 already so I think we just have
to make mNotice a char * and not a const char *

Comment 3

[Roland Mainz]

Comment on attachment 69493 [details] [diff] [review]
quick patch to fix aix bustage

r=[e-mail]

Could you add a comment in the line which says something like "don't try to
make this |const| or the AIX compiler will bite you...|, please ? :)

Comment 4

[Jim Dunn]

Attachment: updated patch, commented and with correct spaces

Comment 5

[Roland Mainz]

Comment on attachment 69502 [details] [diff] [review]
updated patch, commented and with correct spaces

r=[e-mail]

Comment 6

[Roland Mainz]

Fix checked in, marking bug as FIXED.

----

jdunn:
Can you verify, please ?

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Wouldn't it have made more sense to change:

            mPSFontInfo->mNotice = GetAFMString();
            // we really dont want to keep this around...
            delete [] mPSFontInfo->mNotice;
            mPSFontInfo->mNotice = 0;

to:

            delete GetAFMString();
            mPSFontInfo->mNotice = 0;

(Not that this code isn't full of leaks everywhere else...)