120916 - PostScript/Xprint module revamp

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P2)

Description

[Roland Mainz]

Currently I am working on a combined patch (print modules are small pieces of
code, creating single patches may end-up in many bitrot problems and/or patch
dependicies) for the following bugs:
- bug 116139 ("Replace UnixPrData with nsIPrintSettings") 
- bug 116140 ("Remove deprecated paperSize from the Unix printing code") 
- bug 120223 ("Xprint module does not use the given papersize/copies
attributes")
... and many other issues we do not have bugs for...

Comment 1

[Roland Mainz]

Attachment: Patch for 2002-01-17-08-trunk

Comment 2

[Roland Mainz]

Attachment: Better patch for 2002-01-17-08-trunk

Comment 3

[Roland Mainz]

Note that I've sync'ed nsDeviceContextSpecXlib and nsDeviceContextSpecGTK - they
are identical except they use different class names.

----

Requesting r=/sr= ...

... rods ?

Comment 4

[rods (gone)]

nice cleanup  r=rods

Comment 5

[Roland Mainz]

Requesting sr= ...

Comment 6

[Roland Mainz]

Note that you need the patch from bug 120221 to get this one working...

Comment 7

[Roland Mainz]

Attachment: New patch for 2002-01-30-08-trunk

Updated patch to get rid of bitrot and added a fix for bug 122494 ("Xprint has
problems parsing paper size enumerations with tray names") ...

Comment 8

[Roland Mainz]

Attachment: New patch for 2002-02-02-08-trunk

New patch for 2002-02-02-08-trunk to get rid of bitrot + I added a fix for bug
121847 ("PostScript module should add Mozilla version/buildid to print job")
...

Comment 9

[rods (gone)]

r=rods

Comment 10

[dcone (gone)]

r=dcone

Comment 11

[Roland Mainz]

Comment on attachment 67654 [details] [diff] [review]
New patch for 2002-02-02-08-trunk

I have a new patch in the queue to update the XprintUtil library code with my
tree and adjust the patch with the newest NSPR improvements... new patch in a
few hours...

Comment 12

[Roland Mainz]

Attachment: (Hopefully) final patch

Patch for 2002-02-05-08-trunk

Changes:
- XprintUtil API changes
- Fixed "double assertions" in Xprint module (zeo-width/height images usually
have zero image resolution, no need to harass developers twice for the same
issue... :)
- Build warning cleanup (mainly in gfx/src/ps/)

Comment 13

[Roland Mainz]

Attachment: Another patch cycle...

Comment 14

[rods (gone)]

r=rods

Comment 15

[Marc Attinasi]

Comment on attachment 68990 [details] [diff] [review]
Another patch cycle...

rs=attinasi

Some of the naming conventions are wrong though, arguments should start with
'a'.

Comment 16

[timeless]

Comment on attachment 68990 [details] [diff] [review]
Another patch cycle...

Checked in asis

These appear to be the functions which attinasi wants fixed
+NS_IMETHODIMP nsDeviceContextSpecGTK::GetLandscape(PRBool &landscape)
+NS_IMETHODIMP nsDeviceContextSpecGTK::GetTopMargin(float &value)
+NS_IMETHODIMP nsDeviceContextSpecGTK::GetBottomMargin(float &value)
+NS_IMETHODIMP nsDeviceContextSpecGTK::GetRightMargin(float &value)
+NS_IMETHODIMP nsDeviceContextSpecGTK::GetLeftMargin(float &value)

gisburn can make a new patch for that.

Comment 17

[Roland Mainz]

Attachment: Patch to fix BeOS bustage

Comment 18

[Roland Mainz]

Attachment: Patch to fix the typos in main patch (as requested by attinasi)

Comment 19

[timeless]

Comment on attachment 69111 [details] [diff] [review]
Patch to fix BeOS bustage

Applied, still watching

Comment 20

[timeless]

Comment on attachment 69122 [details] [diff] [review]
Patch to fix the typos in main patch (as requested by attinasi)

committed r=timeless

Comment 21

[Roland Mainz]

BeOS tinderbox "BeWildered" went GREEN after checkin of attachment 69111 [details] [diff] [review],
marking bug as FIXED.

Comment 22

[hacker formerly known as [e-mail]]

This checkin (further) broke AIX.

Comment 23

[Roland Mainz]

Filed bug 125341 for the AIX(-only) bustage...

Comment 24

[sujay]

Roland, please verify...thanks!

Comment 25

[Colin Blake]

Broke OpenVMS build too. See bug 125587 for details.

Comment 26

[Roland Mainz]

Marking bug as VERIFIED, everything works as expected, all regressions have been
fixed... :-)