1253423 - Final improvements to fennec feedback on input

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

We need to make a couple changes discussed in long comment thread on bug 1239513. 

1) Get rid of the checkbox for last url, and any logic/param handling around last url. There will be no last url in parameters.

2) Handle a parameter, "utm_source=feedback-settings", which signifies "on device but came here voluntarily". People with this param will get...
* an intent link to the play store
* but no "maybe later" or "no thanks" links  <-- margaret, anthony, do you agree with this second bullet?

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

needinfoing :antlam regarding the second bullet above. If someone goes through the settings to give feedback, I think the only difference from someone coming from the prompt is that the person who came through settings doesn't need a "no thanks" or "maybe later" link. Agree?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Makes sense to me!

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: Screen Shot 2016-03-03 at 1.59.29 PM.png

Can we also remove the banner along the bottom with the link to SUMO? It seems really unfinished and we don't need it really.

We can simply place a link to SUMO before the form like this.

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

We are watching response rates during this change to make sure the change itself hasn't caused a drop in responses. Putting a big opportunity to leave the site above the feedback form could confound our observation. So it'd be better to keep the link in the same place on the page. 

That said, doing anything new (including making sure new text is localized) may be more work than fixing issues you see. When I look at it on device width screens, it looks pretty close to the original. Can you point at specific things that'd make it more polished?

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #4)
> We are watching response rates during this change to make sure the change
> itself hasn't caused a drop in responses. Putting a big opportunity to leave
> the site above the feedback form could confound our observation. So it'd be
> better to keep the link in the same place on the page. 
> 
> That said, doing anything new (including making sure new text is localized)
> may be more work than fixing issues you see. When I look at it on device
> width screens, it looks pretty close to the original. Can you point at
> specific things that'd make it more polished?

The "heart" icon (after feedback is submitted) is a different one now, could we use the original one again? It should still be in the tree.

The "floaty" icon is also incorrect in that the middle void is filled. Given the timeline, could we just remove the icon for now? 

After that, I think it should be fine.

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

Chatted with :antlam in IRC. He said he can give me the original heart (and, optionally, the support icon) in SVG format -- I'll replace those with this work.

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Directed to bug 1175375

Comment 8

[Justin Crawford [:hoosteeno] [:jcrawford]]

PR here: https://github.com/mozilla/fjord/pull/737

Comment 9

[Justin Crawford [:hoosteeno] [:jcrawford]]

This has landed in staging and in prod.