Closed Bug 1253452 Opened 8 years ago Closed 8 years ago

Text in conversation popup can overflow/be hidden/cut off

Categories

(Hello (Loop) :: Client, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Iteration:
48.2 - Apr 4

People

(Reporter: aryx, Assigned: standard8)

References

Details

Attachments

(2 files)

Attached image screenshot of issue
Firefox 46.0a2 20160303004038 in German, Windows 8.1, OS DPI level 125%

Launching a Hello conversation has the description partially hidden on the right side of the conversation pop-up.
Whiteboard: [uxtriage]
Rank: 35
Priority: -- → P3
Whiteboard: [uxtriage]
Comment on attachment 8733448 [details] [review]
[loop] Standard8:bug-1253452-invite > mozilla:master

This fixes the issue - having the 100% width means the layout goes wrong and overflows. Removing that does the right thing.

I've also fixed the UI showcase so that the desktop conversation window gets the right css files and displays the invitation view correctly.
Attachment #8733448 - Flags: review?(edilee)
Attachment #8733448 - Flags: review?(dmose)
Attachment #8733448 - Flags: review?(dcritchley)
Attachment #8733448 - Flags: review?(b.mcb)
Comment on attachment 8733448 [details] [review]
[loop] Standard8:bug-1253452-invite > mozilla:master

Looks good. r=me Ship it!
Attachment #8733448 - Flags: review?(edilee)
Attachment #8733448 - Flags: review?(dmose)
Attachment #8733448 - Flags: review?(dcritchley)
Attachment #8733448 - Flags: review?(b.mcb)
Attachment #8733448 - Flags: review+
https://github.com/mozilla/loop/commit/2624f4fb0d9fba31e4e82ec279fb3d766b530768
Assignee: nobody → standard8
Status: NEW → RESOLVED
Iteration: --- → 48.2 - Apr 4
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 1260811
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: