Land version 1.2.4 of the Loop system add-on in mozilla-central

RESOLVED FIXED in Firefox 46

Status

P1
normal
Rank:
1
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed, firefox48 fixed)

Details

(Whiteboard: [btpp-fix-now], URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
This is a revised 1.2.3 landing. Top-level changes:

- Layout fixes to the invitation views.
- Fix an issue on non-linux platforms, e.g. FreeBSD where the Hello icon isn't displayed due to css not applying there.
- Attempt to fix an intermittent issue found in functional tests when the panel doesn't always close when we expect it.
- Import the latest L10n updates.
(Assignee)

Comment 1

3 years ago
Created attachment 8736388 [details] [diff] [review]
Land version 1.2.4 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.
Attachment #8736388 - Flags: review+
(Assignee)

Comment 2

3 years ago
Created attachment 8736389 [details] [diff] [review]
Land version 1.2.4 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code.
Attachment #8736389 - Flags: review+
(Assignee)

Comment 3

3 years ago
Created attachment 8737146 [details] [diff] [review]
Land version 1.2.4 of the Loop system add-on in mozilla-central. rs=Standard8 for already reviewed code.

Simplifying patches. Moving to a single-patch export.
Attachment #8737146 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8736388 - Attachment is obsolete: true
Attachment #8736389 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Iteration: --- → 48.2 - Apr 4
Rank: 1

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f689d7743268
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

3 years ago
Blocks: 1257947
(Assignee)

Updated

3 years ago
No longer blocks: 1257947
(Assignee)

Comment 6

3 years ago
Comment on attachment 8737146 [details] [diff] [review]
Land version 1.2.4 of the Loop system add-on in mozilla-central. rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Fixes layout issues on the copy urls views that some locales will hit. Also fixes the Hello icon on non-Linux linux like OSes. Locale updates.
[Describe test coverage new/current, TreeHerder]: Has unit tests, landed in m-c for several days now.
[Risks and why]: Low, small improvements to existing code.
[String/UUID change made/needed]: None
Attachment #8737146 - Flags: approval-mozilla-beta?
Attachment #8737146 - Flags: approval-mozilla-aurora?
Comment on attachment 8737146 [details] [diff] [review]
Land version 1.2.4 of the Loop system add-on in mozilla-central. rs=Standard8 for already reviewed code.

Fixes for Hello regressions including missing icons in some version and minor problems for some locales. Late in beta but let's take it for beta 9.
Attachment #8737146 - Flags: approval-mozilla-beta?
Attachment #8737146 - Flags: approval-mozilla-beta+
Attachment #8737146 - Flags: approval-mozilla-aurora?
Attachment #8737146 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 8

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/af4e1dc2e458
status-firefox47: --- → fixed
(Assignee)

Comment 9

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/eb9d7f199164
status-firefox46: --- → fixed
You need to log in before you can comment on or make changes to this bug.