Closed Bug 1260811 Opened 8 years ago Closed 8 years ago

Land version 1.2.4 of the Loop system add-on in mozilla-central

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(firefox46 fixed, firefox47 fixed, firefox48 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla48
Iteration:
48.2 - Apr 4
Tracking Flags:
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(
URL
)

Details

(Whiteboard: [btpp-fix-now])

Attachments

(1 file, 2 obsolete files)

Land version 1.2.4 of the Loop system add-on in mozilla-central. rs=Standard8 for already reviewed code.
40.39 KB, patch
standard8
: review+
lizzard
: approval-mozilla-aurora+
lizzard
: approval-mozilla-beta+
Details | Diff | Splinter Review 
This is a revised 1.2.3 landing. Top-level changes:

- Layout fixes to the invitation views.
- Fix an issue on non-linux platforms, e.g. FreeBSD where the Hello icon isn't displayed due to css not applying there.
- Attempt to fix an intermittent issue found in functional tests when the panel doesn't always close when we expect it.
- Import the latest L10n updates.
Simplifying patches. Moving to a single-patch export.
Attachment #8737146 - Flags: review+
Attachment #8736388 - Attachment is obsolete: true
Attachment #8736389 - Attachment is obsolete: true
Iteration: --- → 48.2 - Apr 4
Rank: 1
https://hg.mozilla.org/mozilla-central/rev/f689d7743268
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Blocks: 1257947
No longer blocks: 1257947
Depends on: 1257947, 1255440, 1253452, 1258329, 1257154, 1258014, 1253013
Comment on attachment 8737146 [details] [diff] [review]
Land version 1.2.4 of the Loop system add-on in mozilla-central. rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Fixes layout issues on the copy urls views that some locales will hit. Also fixes the Hello icon on non-Linux linux like OSes. Locale updates.
[Describe test coverage new/current, TreeHerder]: Has unit tests, landed in m-c for several days now.
[Risks and why]: Low, small improvements to existing code.
[String/UUID change made/needed]: None
Attachment #8737146 - Flags: approval-mozilla-beta?
Attachment #8737146 - Flags: approval-mozilla-aurora?
Comment on attachment 8737146 [details] [diff] [review]
Land version 1.2.4 of the Loop system add-on in mozilla-central. rs=Standard8 for already reviewed code.

Fixes for Hello regressions including missing icons in some version and minor problems for some locales. Late in beta but let's take it for beta 9.
Attachment #8737146 - Flags: approval-mozilla-beta?
Attachment #8737146 - Flags: approval-mozilla-beta+
Attachment #8737146 - Flags: approval-mozilla-aurora?
Attachment #8737146 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.