1253502 - Move python virtualenv initialization to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1253502 - Allow to pass a specific python interpreter to initialize virtualenvs

Review commit: https://reviewboard.mozilla.org/r/38117/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38117/

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1253502 - Move python virtualenv initialization to moz.configure

Review commit: https://reviewboard.mozilla.org/r/38119/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38119/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8726625 [details]
MozReview Request: Bug 1253502 - Allow to pass a specific python interpreter to initialize virtualenvs

https://reviewboard.mozilla.org/r/38117/#review35181

Yay!

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8726626 [details]
MozReview Request: Bug 1253502 - Move python virtualenv initialization to moz.configure

https://reviewboard.mozilla.org/r/38119/#review35187

I still don't like that we create the virtualenv as part of configure. But we can tackle that another day.

::: build/moz.configure/init.configure:146
(Diff revision 1)
> +        manager.build(python)

Since we're now doing this from the virtualenv, I'm pretty sure you can delete the __main__ code from python/mozbuild/mozbuild/virtualenv.py.

Feel free to do that before landing if it is indeed unused.

Comment 5

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #4)
> Comment on attachment 8726626 [details]
> MozReview Request: Bug 1253502 - Move python virtualenv initialization to
> moz.configure
> 
> https://reviewboard.mozilla.org/r/38119/#review35187
> 
> I still don't like that we create the virtualenv as part of configure. But
> we can tackle that another day.

Until we make it impossible to use configure && make (which I'd rather avoid), configure will need to setup the virtualenv if it's not already running in one.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2439b4a42435
https://hg.mozilla.org/integration/mozilla-inbound/rev/33859b1a30fa

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2439b4a42435
https://hg.mozilla.org/mozilla-central/rev/33859b1a30fa