Avoid cumulating dependencies in prepare_configure

RESOLVED FIXED in Firefox 48

Status

()

Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
bug 1254906, bug 1255185, bug 1254410, bug 1253553, and bug 1253502 all need to pass down results from configure.py into old-configure, and it's accumulating in prepare_configure(), which is not convenient. It would be better if we had a helper function that can be called from where those are set instead.
(Assignee)

Comment 1

2 years ago
Created attachment 8728800 [details]
MozReview Request: Bug 1255197 - Avoid cumulating dependencies in prepare_configure()

Review commit: https://reviewboard.mozilla.org/r/39145/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39145/
Attachment #8728800 - Flags: review?(cmanchester)
Attachment #8728800 - Flags: review?(cmanchester) → review+
Comment on attachment 8728800 [details]
MozReview Request: Bug 1255197 - Avoid cumulating dependencies in prepare_configure()

https://reviewboard.mozilla.org/r/39145/#review35967

Very nice. I thought about asking about this before seeing the bug.

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/57e084bd99c6

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/07d255859aff

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/57e084bd99c6
https://hg.mozilla.org/mozilla-central/rev/07d255859aff
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.