Closed Bug 1255197 Opened 4 years ago Closed 4 years ago

Avoid cumulating dependencies in prepare_configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug 1254906, bug 1255185, bug 1254410, bug 1253553, and bug 1253502 all need to pass down results from configure.py into old-configure, and it's accumulating in prepare_configure(), which is not convenient. It would be better if we had a helper function that can be called from where those are set instead.
Attachment #8728800 - Flags: review?(cmanchester) → review+
Comment on attachment 8728800 [details]
MozReview Request: Bug 1255197 - Avoid cumulating dependencies in prepare_configure()

https://reviewboard.mozilla.org/r/39145/#review35967

Very nice. I thought about asking about this before seeing the bug.
https://hg.mozilla.org/mozilla-central/rev/57e084bd99c6
https://hg.mozilla.org/mozilla-central/rev/07d255859aff
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.