Closed Bug 1255197 Opened 4 years ago Closed 4 years ago
Avoid cumulating dependencies in prepare
58 bytes, text/x-review-board-request
bug 1254906, bug 1255185, bug 1254410, bug 1253553, and bug 1253502 all need to pass down results from configure.py into old-configure, and it's accumulating in prepare_configure(), which is not convenient. It would be better if we had a helper function that can be called from where those are set instead.
Review commit: https://reviewboard.mozilla.org/r/39145/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39145/
Attachment #8728800 - Flags: review?(cmanchester)
Attachment #8728800 - Flags: review?(cmanchester) → review+
Comment on attachment 8728800 [details] MozReview Request: Bug 1255197 - Avoid cumulating dependencies in prepare_configure() https://reviewboard.mozilla.org/r/39145/#review35967 Very nice. I thought about asking about this before seeing the bug.
You need to log in before you can comment on or make changes to this bug.