1255197 - Avoid cumulating dependencies in prepare_configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

bug 1254906, bug 1255185, bug 1254410, bug 1253553, and bug 1253502 all need to pass down results from configure.py into old-configure, and it's accumulating in prepare_configure(), which is not convenient. It would be better if we had a helper function that can be called from where those are set instead.

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1255197 - Avoid cumulating dependencies in prepare_configure()

Review commit: https://reviewboard.mozilla.org/r/39145/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39145/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8728800 [details]
MozReview Request: Bug 1255197 - Avoid cumulating dependencies in prepare_configure()

https://reviewboard.mozilla.org/r/39145/#review35967

Very nice. I thought about asking about this before seeing the bug.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57e084bd99c6

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07d255859aff

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/57e084bd99c6
https://hg.mozilla.org/mozilla-central/rev/07d255859aff