1253930 - Default favicons of 5 recently bookmarked, while in smart folder favicons are OK

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Krzysztof]

Attachment: Recent bookmarks bug.jpg

User Agent: Mozilla/5.0 (Windows NT 6.0; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160305030241

Steps to reproduce:

I've noticed a bug in the bookmarks menu.


Actual results:

As in attached screenshot: Favicons of 5 recently bookmarked pages are default (globes). But in smart folder Recently bookmarked and in real folders the same links have specific favicons.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=970aa793c5e2778172cd8e527f9dc04848400d40&tochange=f7149b0bcf7491e23edacbffce6fa418b05e776e

Regressed by: f7149b0bcf74	Dão Gottwald — Bug 1250806 - Add menuitems for recent bookmarks synchronously so that they show up in the native menubar on OS X. r=mak

Comment 2

[Benjamin Kerensa [:bkerensa]]

Going to track this regression and see if Dao can take this

Comment 3

[Marco Bonardo [:mak]]

I can take this, the problem is that nsINavHistoryResult already provides a moz-anno:favicon: url, so we don't need to add the prefix.

Comment 4

[Marco Bonardo [:mak]]

Attachment: MozReview Request: Bug 1253930 - Recently bookmarked items have the default favicon instead of the correct one. r=dao

Review commit: https://reviewboard.mozilla.org/r/38451/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38451/

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4b613cad02de

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4b613cad02de

Comment 7

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to reproduce this issue on Firefox 47.0a1 (2016-03-05) and on Windows 10 x86.
The issue is no longer reproducible on Firefox 48.0a1 (2016-03-08). The tests were performed on Windows 10 x86, Mac OS X 10.11.1 and on Ubuntu 14.04 x64.
I am marking this issue Verified-Fixed.

Comment 8

[Marco Bonardo [:mak]]

Recent bookmarks have been disabled in 47, so we don't need this.