Closed Bug 1254040 Opened 8 years ago Closed 8 years ago

[TV][Home] Remove expanding/shrinking motion for filters

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.6+)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.6+

People

(Reporter: rexboy, Assigned: lchang)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] luke-chang:1254040_tv_remove_filter_shrinking > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review 
Filters are now shown by default. We don't expand or shrink them.
Assignee: nobody → lchang
Comment on attachment 8728222 [details] [review]
[gaia] luke-chang:1254040_tv_remove_filter_shrinking > mozilla-b2g:master

Hi Rex,

I removed the use of "menu-group" entirely. Could you take a look at this? Thanks.
Attachment #8728222 - Flags: review?(rexboy)
blocking-b2g: --- → 2.6?
Whiteboard: [ft:conndevices]
Comment on attachment 8728222 [details] [review]
[gaia] luke-chang:1254040_tv_remove_filter_shrinking > mozilla-b2g:master

r=me!
Attachment #8728222 - Flags: review?(rexboy) → review+
You can try removing
- mock_menu_group
- setTimeout to requestAnimationFrame
if you're available.
Hi Rex,

That's good point! Have fixed that. Thanks.

landed on master: https://github.com/mozilla-b2g/gaia/commit/c5e316e67264753e38c301f9a20a6334e758ae00
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
blocking-b2g: 2.6? → 2.6+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: