Build system changes for the transitioned Gaia

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fabrice, Assigned: gerard-majax)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
This is to prepare for a chrome:// served Gaia. Instead of packaging each app independently in an application.zip file, we will package them all together, and put the shared/ alongside the apps.
The directory tree will look like:

|- shared
|- system
|- settings
|- ...

Compared to today's builds, we have to:
- stop including shared/ in every app.
- still select images at the appropriate resolution.
- stop packaging apps individually.
- stop using the gaiamobile.org subdomain.
(Assignee)

Comment 1

3 years ago
I'll try to hack on this.
Assignee: nobody → lissyx+mozillians
Created attachment 8729035 [details] [review]
[gaia] lissyx:bug1254281_transition_gaia > mozilla-b2g:kanikani
(Assignee)

Comment 3

3 years ago
Current status is that building profile fails around settings + shared with require.js doing stuff.
(Assignee)

Comment 4

3 years ago
(In reply to Alexandre LISSY :gerard-majax from comment #3)
> Current status is that building profile fails around settings + shared with
> require.js doing stuff.

Should be fixed now, builds profile/webapps and hacked to copy shared/:
> LC_ALL=C ll profile/webapps/
> total 32K
> drwxr-xr-x  7 alex alex 4.0K Mar 14 14:20 .
> drwxrwxr-x  5 alex alex 4.0K Mar 14 14:20 ..
> drwxr-xr-x  7 alex alex 4.0K Mar 14 14:20 homescreen
> drwxr-xr-x  6 alex alex 4.0K Mar 14 14:20 keyboard
> drwxr-xr-x  8 alex alex 4.0K Mar 14 14:20 settings
> drwxr-xr-x  9 alex alex 4.0K Mar 14 14:20 shared
> drwxr-xr-x 11 alex alex 4.0K Mar 14 14:20 system
> -rw-rw-r--  1 alex alex 1.4K Mar 14 14:20 webapps.json
(Assignee)

Comment 5

3 years ago
With bug 1256506 moving forward, I am going to try and wrap up this to push to kanikani by the end of the week :)
(Assignee)

Comment 6

3 years ago
Good news: after some more path hacking, I am getting into a state where:
 - make clean && make PRODUCTION=1 profile
 - adb shell rm -r /system/b2g/apps/*
 - adb push profile/webapps/ /system/b2g/apps/

Results in system app basically booting, with few enough errors so that homescreen background is visible, lockscreen is visible (with date, time and slider working) and opening a new browser window works.
(Assignee)

Updated

3 years ago
Depends on: 832165
(Assignee)

Comment 7

3 years ago
Created attachment 8732136 [details]
git grep "webapps" | grep -v -E "^apps\/|^tv_apps\/|^tools\/|webapps-manage|^build/test/|^tests/"

Used to identify the places where we want to change "webapps" to "apps" to transition from /system/b2g/webapps to /system/b2g/apps

Aus, this might likely break test infras :)
Flags: needinfo?(aus)
(Assignee)

Comment 8

3 years ago
make APP=xxx install-gaia fixed too.
(Assignee)

Comment 9

3 years ago
make reset-gaia works
(Assignee)

Comment 10

3 years ago
and we are now pushing/installing to /system/b2g/apps, I am fixing |./build.sh| to be working properly with this and it will be good to merge.
(Assignee)

Comment 11

3 years ago
This is suboptimal, but Android build system really don't seem to love Android.mk leaving out of his build tree. So you might have to deal with changing your B2G build tree's gaia/Android.mk to reference "apps" instead of "webapps".
(Assignee)

Comment 12

3 years ago
Created attachment 8732221 [details]
local changes for |./build.sh| to pass

I don't think we need/can land those outside of pine/kanikani, too intrusive. On the other hand, it's just a one time easy to apply patch.
(Assignee)

Comment 13

3 years ago
Time to land, this is booting, we can iterate over from this.
(Assignee)

Comment 14

3 years ago
https://github.com/mozilla-b2g/gaia/commit/48f61f5996b6ed3d955676432a2f64669273b104
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1257925
(Assignee)

Updated

3 years ago
Depends on: 1258345
(Assignee)

Comment 15

3 years ago
FYI, turns out building with GAIA_PATH exported does not really work that well. Please refrain from trying to do this and just checkout gaia kanikani in your B2G/gaia/.

Comment 16

3 years ago
Thanks for the heads up, now that the tests are running as expected again, I can go ahead and fix those. =)
Flags: needinfo?(aus)
You need to log in before you can comment on or make changes to this bug.